Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time frames #391

Open
waynetrav opened this issue Feb 17, 2021 · 2 comments
Open

Time frames #391

waynetrav opened this issue Feb 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@waynetrav
Copy link

Is your feature request related to a problem? Please describe.
The CE rules and both versions of MGT have a time frame modifier in the skill rolls section. Having the ability to select a time frame would be useful in a lot of gaming situations, and in my experience it is often overlooked.

Describe the solution you'd like
An optional drop down for skill rolls, where a particular time frame is selected and then the randomized result is presented along with the roll.

Describe alternatives you've considered
Just doing it myself. Finding the mod and applying it to the pop up.

Additional context
Page 32, CE rules: "Going Faster or Slower. You can choose, before you roll, to move up or down one or two rows on the Time Frames table. Moving up (reducing the time increment) gives you a -1 DM for every row you move; moving down and increasing the time taken gives you a +1 DM for every row you move. Your Referee will help adjudicate any issues that might arise from a change in the time frame."

@xdy
Copy link
Owner

xdy commented Feb 28, 2021

At one point I had intended to add this but got distracted by something else. One code remnant still exists in settings.ts line 50:

_numberSetting('absoluteBonusValueForEachTimeIncrement', -1);

The intent was to use this value instead of the -1 from the CE rules to enable supporting other variant rules.

For whoever tackles this issue, note that neither of Cepheus Light, Cepheus Faster Than Light or Cepheus Atom use timeframes, so a 0 in should probably be interpreted as 'do not roll random time'
Also, note that CE, MGT1 and MGT2 all use different lengths for the various timeframes, so this needs to be supported. Either directly in settings, or by pointing to a Rollable Table (with such a table provided for CE but none of the others) that is then used by the code creating the randomized result.

@jonepatr jonepatr added the enhancement New feature or request label Jan 7, 2022
@marvin9257
Copy link
Collaborator

PR #1007 Add a timeframe selection to skill rolls but no ability to take longer or shorter - just roll the task duration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants