You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I was using Config from "types/config.d.ts" in order to allow type safety and code suggestions in my project. I found out that the Config class from "types/config.d.ts" is out of sync with the IViewOptions interface (see comments I made):
interfaceIViewOptionsextendsILanguageOptions,IToolbarOptions{/** * Use cache for heavy methods */cache?: boolean;// mandatory in types/config.d.tsgetIcon?: (name: string,clearName: string)=>CanUndef<string>;// missingheaderButtons?: string|Array<IControlType|string|ButtonsGroup>;// missingbasePath?: string;theme?: string;// mandatory in types/config.d.tsdefaultTimeout?: number;// mandatory in types/config.d.tsdisabled?: boolean;// mandatory in types/config.d.tsreadonly?: boolean;// mandatory in types/config.d.tsiframe?: boolean;// mandatory in types/config.d.tsnamespace?: string;// mandatory in types/config.d.tsactiveButtonsInReadOnly?: string[];// mandatory in types/config.d.tsallowTabNavigation?: boolean;// mandatory in types/config.d.tszIndex?: number|string;// mandatory in types/config.d.tsfullsize?: boolean;// missingglobalFullSize?: boolean;// missingcontrols?: Controls;// mandatory in types/config.d.tscreateAttributes?: IDictionary<Attributes|NodeFunction>;// mandatory in types/config.d.tsevents?: IDictionary<(...args: any[])=>any>;// mandatory in types/config.d.tsshadowRoot?: Nullable<ShadowRoot>;ownerWindow?: Window;// mandatory in types/config.d.tslanguage?: string;// mandatory in types/config.d.ts}interfaceILanguageOptions{language?: string;// mandatory in types/config.d.tsdebugLanguage?: boolean;// mandatory in types/config.d.tsi18n?: IDictionary<IDictionary<string>>|false;// mandatory in types/config.d.ts}interfaceIToolbarOptions{toolbar?: boolean|string|HTMLElement;// mandatory in types/config.d.tsreadonlytheme?: string;// mandatory in types/config.d.tsreadonlytoolbarButtonSize?: IUIButtonState['size'];// mandatory in types/config.d.tsreadonlytextIcons?: boolean|((key: string)=>boolean);// mandatory in types/config.d.tsreadonlyextraButtons?: Buttons;// mandatory in types/config.d.tsreadonlyremoveButtons?: string[];// mandatory in types/config.d.tsreadonlyextraIcons?: IDictionary<string>;// mandatory in types/config.d.tsreadonlybuttons?: ButtonsOption;// mandatory in types/config.d.tsreadonlyshowTooltip?: boolean;// mandatory in types/config.d.tsreadonlyshowTooltipDelay?: number;// mandatory in types/config.d.tsreadonlyuseNativeTooltip?: boolean;// mandatory in types/config.d.tsreadonlydirection?: string;// mandatory in types/config.d.ts}
I assume that the Config class is the class that typescript devs should use for defining the type of options? At the moment the Config class does not represent the optional and mandatory options that are handled by Jodit. Can you please update this class? If done that would help TS devs a lot and I could change the type definition in ngx-jodit 😄
The text was updated successfully, but these errors were encountered:
Jodit 4.2.27
Jodit.make(element, options)
doesn't declare the type foroptions
. There should be a type definition instead of just "object".Config
from "types/config.d.ts" in order to allow type safety and code suggestions in my project. I found out that the Config class from "types/config.d.ts" is out of sync with the IViewOptions interface (see comments I made):I assume that the Config class is the class that typescript devs should use for defining the type of options? At the moment the Config class does not represent the optional and mandatory options that are handled by Jodit. Can you please update this class? If done that would help TS devs a lot and I could change the type definition in ngx-jodit 😄
The text was updated successfully, but these errors were encountered: