Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction confirmation screen #22

Closed
BrandtH22 opened this issue Sep 26, 2024 · 4 comments
Closed

Add transaction confirmation screen #22

BrandtH22 opened this issue Sep 26, 2024 · 4 comments

Comments

@BrandtH22
Copy link
Collaborator

Add transaction confirmation screen (currently reverts back to token list but hangs on the transaction screen while submitting)

@Rigidity Rigidity added this to Sage Sep 26, 2024
@Rigidity
Copy link
Collaborator

@BrandtH22 is this still an issue, now that the coins will be displayed as pending a transaction? In other words, was the problem lack of UI feedback or lack of confirmation?

@BrandtH22
Copy link
Collaborator Author

I think the transaction confirmation that does appear would be nice to have the coinIDs that will be used in the transaction but that could be me just liking to have more data than needed

@Rigidity
Copy link
Collaborator

I think the transaction confirmation that does appear would be nice to have the coinIDs that will be used in the transaction but that could be me just liking to have more data than needed

I think maybe having a generic transaction confirmation screen that shows all inputs and outputs would make sense. So it builds the full spend bundle, displays it, then adds it to the transactions table if confirmed. This could be reused for WalletConnect and offers

@Rigidity
Copy link
Collaborator

Resolved in #61 :)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Sage Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants