You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there are two issues on xarray about xr.corr, from which we can improve xr.pearson_r and in general:
pydata/xarray#4804: use a, b = xr.align(a, b, exclude=dim) as broadcast has join="outer" which fills it with NA which then get ignored; align uses join="inner". I remember I implemented that, but I am no broadcasting/align expert. I was just happy tests passed...
Here we are also not sure why xs.pearson_r is faster than xr.corr
there are two issues on
xarray
aboutxr.corr
, from which we can improvexr.pearson_r
and in general:pydata/xarray#4804: use
a, b = xr.align(a, b, exclude=dim)
asbroadcast
hasjoin="outer"
which fills it withNA
which then get ignored;align
usesjoin="inner"
. I remember I implemented that, but I am no broadcasting/align expert. I was just happy tests passed...Here we are also not sure why
xs.pearson_r
is faster thanxr.corr
pydata/xarray#4768: I raised whether to implement
weighted
inxr.corr
The text was updated successfully, but these errors were encountered: