udp: allow configurable max packet size (envoyproxy#15388)

1) Add configuration for max packet size to UDP listeners
2) Add configuration for max packet size to UDP proxy filter
3) Fix crashing issue when a GRO receive is truncated. This
   was fixed in the open because GRO recieve does not support
   IP fragmentation, thus the previous size of 24000 bytes was
   large enough to receive a jumbo frame size datagram. The issue
   is now exposed by allowing packet size to be configured larger.
4) Reorganize code and some config around UDP listeners to streamline
   the logic when the listener is a UDP listener. Also moved the UDP
   batch writer configuration to a better place since it's still
   effectively alpha and was marked not implemented.

Fixes envoyproxy#15327

Signed-off-by: Matt Klein <[email protected]>

Author: mattklein123

api/envoy/config/listener/v3/listener.proto

@@ -5,7 +5,6 @@ package envoy.config.listener.v3;
 import "envoy/config/accesslog/v3/accesslog.proto";
 import "envoy/config/core/v3/address.proto";
 import "envoy/config/core/v3/base.proto";
-import "envoy/config/core/v3/extension.proto";
 import "envoy/config/core/v3/socket_option.proto";
 import "envoy/config/listener/v3/api_listener.proto";
 import "envoy/config/listener/v3/listener_components.proto";
@@ -93,7 +92,7 @@ message Listener {
   message InternalListenerConfig {
   }
 
-  reserved 14;
+  reserved 14, 23;
 
   // The unique name by which this listener is known. If no name is provided,
   // Envoy will allocate an internal UUID for the listener. If the listener is to be dynamically
@@ -216,10 +215,8 @@ message Listener {
 
   // If the protocol in the listener socket address in :ref:`protocol
   // <envoy_api_field_config.core.v3.SocketAddress.protocol>` is :ref:`UDP
-  // <envoy_api_enum_value_config.core.v3.SocketAddress.Protocol.UDP>`, this field specifies the actual udp
-  // listener to create, i.e. :ref:`udp_listener_name
-  // <envoy_api_field_config.listener.v3.UdpListenerConfig.udp_listener_name>` = "raw_udp_listener" for
-  // creating a packet-oriented UDP listener. If not present, treat it as "raw_udp_listener".
+  // <envoy_api_enum_value_config.core.v3.SocketAddress.Protocol.UDP>`, this field specifies UDP
+  // listener specific configuration.
   UdpListenerConfig udp_listener_config = 18;
 
   // Used to represent an API listener, which is used in non-proxy clients. The type of API
@@ -261,16 +258,6 @@ message Listener {
   // emitted by this listener.
   repeated accesslog.v3.AccessLog access_log = 22;
 
-  // If the protocol in the listener socket address in :ref:`protocol
-  // <envoy_api_field_config.core.v3.SocketAddress.protocol>` is :ref:`UDP
-  // <envoy_api_enum_value_config.core.v3.SocketAddress.Protocol.UDP>`, this field specifies the actual udp
-  // writer to create, i.e. :ref:`name <envoy_api_field_config.core.v3.TypedExtensionConfig.name>`
-  //    = "udp_default_writer" for creating a udp writer with writing in passthrough mode,
-  //    = "udp_gso_batch_writer" for creating a udp writer with writing in batch mode.
-  // If not present, treat it as "udp_default_writer".
-  // [#not-implemented-hide:]
-  core.v3.TypedExtensionConfig udp_writer_config = 23;
-
   // The maximum length a tcp listener's pending connections queue can grow to. If no value is
   // provided net.core.somaxconn will be used on Linux and 128 otherwise.
   google.protobuf.UInt32Value tcp_backlog_size = 24;

api/envoy/config/listener/v3/listener_components.proto

@@ -338,7 +338,7 @@ message ListenerFilter {
   oneof config_type {
     // Filter specific configuration which depends on the filter being
     // instantiated. See the supported filters for further documentation.
-    // [#extension-category: envoy.filters.listener]
+    // [#extension-category: envoy.filters.listener,envoy.filters.udp_listener]
     google.protobuf.Any typed_config = 3;
   }
 

api/envoy/config/listener/v3/quic_config.proto

@@ -15,11 +15,11 @@ option java_outer_classname = "QuicConfigProto";
 option java_multiple_files = true;
 option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
-// [#protodoc-title: QUIC listener Config]
-// [#extension: envoy.listener.quic]
+// [#protodoc-title: QUIC listener config]
+// [#comment:#extension: envoy.udp_listeners.quiche_quic_listener]
+// [#comment:TODO(#12829): Remove this as an extension point.]
 
-// Configuration specific to the QUIC protocol.
-// Next id: 5
+// Configuration specific to the UDP QUIC listener.
 message QuicProtocolOptions {
   option (udpa.annotations.versioning).previous_message_type =
       "envoy.api.v2.listener.QuicProtocolOptions";

api/envoy/config/listener/v3/udp_gso_batch_writer_config.proto

@@ -9,9 +9,11 @@ option java_outer_classname = "UdpGsoBatchWriterConfigProto";
 option java_multiple_files = true;
 option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
-// [#protodoc-title: Udp Gso Batch Writer Config]
+// [#protodoc-title: UDP GSO Batch Writer]
+// [#comment:#extension: envoy.udp_packet_writers.udp_gso_batch_writer]
 
+// Configuration specific to the UDP GSO Batch Writer.
 // [#not-implemented-hide:]
-// Configuration specific to the Udp Gso Batch Writer.
+// [#comment:TODO(#12829): Remove this as an extension point.]
 message UdpGsoBatchWriterOptions {
 }

api/envoy/config/listener/v3/udp_listener_config.proto

@@ -2,38 +2,53 @@ syntax = "proto3";
 
 package envoy.config.listener.v3;
 
+import "envoy/config/core/v3/extension.proto";
+
 import "google/protobuf/any.proto";
+import "google/protobuf/wrappers.proto";
 
 import "udpa/annotations/status.proto";
 import "udpa/annotations/versioning.proto";
+import "validate/validate.proto";
 
 option java_package = "io.envoyproxy.envoy.config.listener.v3";
 option java_outer_classname = "UdpListenerConfigProto";
 option java_multiple_files = true;
 option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
-// [#protodoc-title: UDP Listener Config]
+// [#protodoc-title: UDP listener config]
 // Listener :ref:`configuration overview <config_listeners>`
 
+// [#next-free-field: 7]
 message UdpListenerConfig {
   option (udpa.annotations.versioning).previous_message_type =
       "envoy.api.v2.listener.UdpListenerConfig";
 
-  reserved 2;
+  reserved 1, 2, 3;
 
   reserved "config";
 
-  // Used to look up UDP listener factory, matches "raw_udp_listener" or
-  // "quic_listener" to create a specific udp listener.
-  // If not specified, treat as "raw_udp_listener".
-  string udp_listener_name = 1;
-
-  // Used to create a specific listener factory. To some factory, e.g.
-  // "raw_udp_listener", config is not needed.
-  // [#extension-category: envoy.filters.udp_listener]
-  oneof config_type {
-    google.protobuf.Any typed_config = 3;
-  }
+  // Used to create a specific UDP listener factory. If not specified the default UDP listener is
+  // used.
+  // [#comment:#extension-category: envoy.udp_listeners]
+  // [#not-implemented-hide:]
+  // [#comment:TODO(#12829): Remove this as an extension point.]
+  core.v3.TypedExtensionConfig listener_config = 4;
+
+  // The maximum size of received downstream UDP datagrams. Using a larger size will cause Envoy to allocate
+  // more memory per listener. Received datagrams above this size will be dropped. If not set
+  // defaults to 1500 bytes.
+  google.protobuf.UInt64Value max_downstream_rx_datagram_size = 5
+      [(validate.rules).uint64 = {lt: 65536 gt: 0}];
+
+  // If the protocol in the listener socket address in :ref:`protocol
+  // <envoy_api_field_config.core.v3.SocketAddress.protocol>` is :ref:`UDP
+  // <envoy_api_enum_value_config.core.v3.SocketAddress.Protocol.UDP>`, this field specifies the
+  // actual UDP writer to create. If not specified the default UDP writer is used.
+  // [#comment:#extension-category: envoy.udp_packet_writers]
+  // [#not-implemented-hide:]
+  // [#comment:TODO(#12829): Remove this as an extension point.]
+  core.v3.TypedExtensionConfig writer_config = 6;
 }
 
 message ActiveRawUdpListenerConfig {

api/envoy/config/listener/v4alpha/listener.proto

@@ -3,6 +3,7 @@ syntax = "proto3";
 package envoy.extensions.filters.udp.udp_proxy.v3;
 
 import "google/protobuf/duration.proto";
+import "google/protobuf/wrappers.proto";
 
 import "udpa/annotations/status.proto";
 import "udpa/annotations/versioning.proto";
@@ -18,7 +19,7 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
 // [#extension: envoy.filters.udp_listener.udp_proxy]
 
 // Configuration for the UDP proxy filter.
-// [#next-free-field: 6]
+// [#next-free-field: 7]
 message UdpProxyConfig {
   option (udpa.annotations.versioning).previous_message_type =
       "envoy.config.filter.udp.udp_proxy.v2alpha.UdpProxyConfig";
@@ -68,4 +69,10 @@ message UdpProxyConfig {
   // load balancing algorithms will select a host randomly. Currently the number of hash policies is
   // limited to 1.
   repeated HashPolicy hash_policies = 5 [(validate.rules).repeated = {max_items: 1}];
+
+  // The maximum size of received upstream UDP datagrams. Using a larger size will cause Envoy to allocate
+  // more memory per listener. Received datagrams above this size will be dropped. If not set
+  // defaults to 1500 bytes.
+  google.protobuf.UInt64Value max_upstream_rx_datagram_size = 6
+      [(validate.rules).uint64 = {lt: 65536 gt: 0}];
 }

api/envoy/config/listener/v4alpha/listener_components.proto

@@ -13,7 +13,8 @@ option java_multiple_files = true;
 option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
 // [#protodoc-title: quic transport]
-// [#extension: envoy.transport_sockets.quic]
+// [#comment:#extension: envoy.transport_sockets.quic]
+// [#comment:TODO(#12829): Remove this as an extension point.]
 
 // Configuration for Downstream QUIC transport socket. This provides Google's implementation of Google QUIC and IETF QUIC to Envoy.
 message QuicDownstreamTransport {

api/envoy/config/listener/v4alpha/quic_config.proto

@@ -774,7 +774,7 @@ REPOSITORY_LOCATIONS_SPEC = dict(
         sha256 = "3045254cbf03c29ee7166fb01b1072a463c58df405669b8573677d4638869290",
         urls = ["https://storage.googleapis.com/quiche-envoy-integration/{version}.tar.gz"],
         use_category = ["dataplane_ext"],
-        extensions = ["envoy.transport_sockets.quic", "envoy.listener.quic"],
+        extensions = ["envoy.transport_sockets.quic", "envoy.udp_listeners.quiche_quic_listener"],
         release_date = "2021-02-24",
         cpe = "N/A",
     ),

api/envoy/config/listener/v4alpha/udp_gso_batch_writer_config.proto

@@ -14,12 +14,15 @@ static_resources:
         protocol: UDP
         address: 127.0.0.1
         port_value: 1234
+    udp_listener_config:
+      max_downstream_rx_datagram_size: 9000
     listener_filters:
     - name: envoy.filters.udp_listener.udp_proxy
       typed_config:
         '@type': type.googleapis.com/envoy.extensions.filters.udp.udp_proxy.v3.UdpProxyConfig
         stat_prefix: service
         cluster: service_udp
+        max_upstream_rx_datagram_size: 9000
   clusters:
   - name: service_udp
     connect_timeout: 0.25s

api/envoy/config/listener/v4alpha/udp_listener_config.proto

@@ -47,7 +47,8 @@ Example configuration
 ---------------------
 
 The following example configuration will cause Envoy to listen on UDP port 1234 and proxy to a UDP
-server listening on port 1235.
+server listening on port 1235, allowing 9000 byte packets in both directions (i.e., either jumbo
+frames or fragmented IP packets).
 
 .. literalinclude:: _include/udp-proxy.yaml
     :language: yaml

api/envoy/extensions/filters/udp/udp_proxy/v3/udp_proxy.proto

@@ -524,7 +524,7 @@ response header/body with end-stream set are received. This is handled in
 It is possible for a request to terminate early. This may be due to (but not limited to):
 
 * Request timeout.
-* Upstream endpoint steam reset.
+* Upstream endpoint stream reset.
 * HTTP filter stream reset.
 * Circuit breaking.
 * Unavailability of upstream resources, e.g. missing a cluster for a route.