Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a preview of the components with the documentation website #159

Closed
frankieroberto opened this issue Nov 1, 2023 · 3 comments · Fixed by #175
Closed

Include a preview of the components with the documentation website #159

frankieroberto opened this issue Nov 1, 2023 · 3 comments · Fixed by #175
Labels
enhancement New feature or request

Comments

@frankieroberto
Copy link
Contributor

The documentation website doesn’t currently include any previews of the components.

We should figure out how to add previews - in a similar way to the Design System website or the Ruby components website maybe?

@frankieroberto frankieroberto added the enhancement New feature or request label Nov 1, 2023
@paulrobertlloyd
Copy link
Contributor

paulrobertlloyd commented Nov 17, 2023

I looked at this when we first put together the website. We could create a component to include an iframe on the documentation page, but that would need additional behaviour to auto-expand to the contained example which is non-trivial. The other, simpler, option is to include an image.

@frankieroberto
Copy link
Contributor Author

Images sound hard to maintain - although would be better than nothing.

Is it possible to avoid iframes and and just embed the components on the page directly, or is that tricky because reasons?

@paulrobertlloyd
Copy link
Contributor

I’ve just tried to create standalone example pages, which you could link to as an MVP, and show in an iframe later… it certainly wasn’t coming together easily.

That’s partly because this project isn’t setup like the others (yet) – note the lack of homepage illustration, for example. Instead, it renders the various README.md files and creates a website from those. Really it needs a separate docs site created, which may provide more flexibility to create example pages and then embed them in frames, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants