Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs:style] It is recommended to adjust the color scheme of the document text #936

Open
you-hengh opened this issue Aug 28, 2024 · 5 comments
Labels
docs Improvements or additions to documentation feature good first issue Want to contribute to WXT? This is a good place to start

Comments

@you-hengh
Copy link

Feature Request

The accent color in the current document is light green, which makes the text appear unclear against a white background and more laborious to read. I suggest changing the accent color to dark, which will make the text more prominent and clear, allowing people to concentrate on reading without having to worry about vision problems.

Is your feature request related to a bug?

N/A

What are the alternatives?

Although I am not a professional designer, I think using purple text in daytime mode might have a good effect, as shown in the image below:
2024-08-28_13-44-18

Additional context

I am learning how to use WXT, and I am still at the beginning stage. Hope WXT can do better and better!

@parnavh
Copy link

parnavh commented Aug 28, 2024

What is this? Are you here to advertise? Is this a Trojan horse virus or fraudulent software?

I'm guessing something you don't want, these bots seem to be flooding every issue

@you-hengh
Copy link
Author

What is this? Are you here to advertise? Is this a Trojan horse virus or fraudulent software?

I'm guessing something you don't want, these bots seem to be flooding every issue

The first time I saw such a message on GitHub, probably because I am not active enough. Well, we should probably stop discussing this extraneous topic. I don't know how to fold these extraneous topics, maybe I don't have enough permissions!

@1natsu172
Copy link
Contributor

When talking about accessibility like this, it is better to eliminate subjectivity and follow the WCAG guide.

A good way to proceed would be to use the contrast tool in the ChromeDevTools. (Guide: https://developer.chrome.com/docs/devtools/accessibility/contrast)

And at least as you feel, most of the current colors seem to be less than AA.
image

@github-staff github-staff deleted a comment Aug 28, 2024
@github-staff github-staff deleted a comment from you-hengh Aug 28, 2024
@aklinker1
Copy link
Collaborator

Ugh I hate changing the colors in vitepress... But you guys are right, there's not enough contrast! I'm a dark theme person, so I don't look at the light theme often lol. I'll get both up to par with the standards.

@aklinker1 aklinker1 added docs Improvements or additions to documentation good first issue Want to contribute to WXT? This is a good place to start labels Aug 29, 2024
@aklinker1
Copy link
Collaborator

Although I am not a professional designer, I think using purple text in daytime mode might have a good effect

WXT's theme is green, so no, I will not be using purple. Will be sticking to green, and just adjusting the lightness/saturation until it meets the standards, at least AA. AAA can be difficult to achieve, at least for lighter colors like green. I'll try AAA first, but if it's too dark, might just only support AA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feature good first issue Want to contribute to WXT? This is a good place to start
Projects
Status: Todo
Development

No branches or pull requests

4 participants