Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting astjson package for non-GraphQL use cases? #695

Open
andyfeller opened this issue Dec 11, 2023 · 2 comments
Open

Adopting astjson package for non-GraphQL use cases? #695

andyfeller opened this issue Dec 11, 2023 · 2 comments
Labels
internally-reviewed Internally reviewed

Comments

@andyfeller
Copy link

andyfeller commented Dec 11, 2023

Describe the feature or problem you’d like to solve

Understand how the astjson package might be adopted as a module for non-GraphQL router specific use cases such as cli/cli#1268 as an alternative to https://github.com/darccio/mergo.

UPDATE: In retrospective, it appears astjson uses mergo under the covers, so understanding what graphql-go-tools adds on top.

Additional context

@jensneuse : saw your WunderGraph article on performance improvements with astjson at a time where the GitHub CLI team has been trying to figure out how to do something similar with GitHub API requests. In our case, we are making REST and GraphQL API requests on behalf of GitHub users who want / expect a single JSON document when the REST and GraphQL APIs require multiple requests made due to rate limiting.

Would appreciate any thoughts and insights you might share!

@jensneuse
Copy link
Member

Hey, astjson doesn't use mergo. It's an indirect dependency, not sure where it's being used.

I was already thinking that astjson could be useful for other use cases outside of GraphQL, so making it a standalone go module could be useful. That said, I didn't want to act without a clear need. WDYT?

@andyfeller
Copy link
Author

I will say it is something I brought up to the other GitHub CLI maintainers as we discuss how to improve our own product experience. Will float this also by @heaths given his time investment on this feature, but I can say it would be valuable in and of itself! 💯

Thank you for taking the time to consider a broader OSS audience, @jensneuse

@StarpTech StarpTech added the internally-reviewed Internally reviewed label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internally-reviewed Internally reviewed
Projects
None yet
Development

No branches or pull requests

3 participants