Skip to content
This repository has been archived by the owner on Jun 28, 2019. It is now read-only.

Wrong CRC calculation in upgrade_crc_check #9

Open
hammer-dp-ua opened this issue Mar 9, 2017 · 1 comment
Open

Wrong CRC calculation in upgrade_crc_check #9

hammer-dp-ua opened this issue Mar 9, 2017 · 1 comment

Comments

@hammer-dp-ua
Copy link

hammer-dp-ua commented Mar 9, 2017

Please rollback a change made in 10.25.2016 08:27:15 by SeregaKai.
abs function was placed not just by mistake. Looks like it converts "unsigned int" to "int" inside itself and then really changes bitwise representation if int result is negative.

@borro0
Copy link

borro0 commented Jul 23, 2018

I agree on this. The gen_appbin.py used to generate the crc in the first place, also uses abs.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants