Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify all service-verticle Configurations to allow default configs #300

Open
cb0s opened this issue Jun 30, 2021 · 1 comment
Open

Modify all service-verticle Configurations to allow default configs #300

cb0s opened this issue Jun 30, 2021 · 1 comment
Labels
📚 documentation Improvements or additions to documentation 📄 java Pull requests that update Java code 🌷 enhancement New feature or request 🔧 telestion-api Everything related to the telestion-api module
Milestone

Comments

@cb0s
Copy link
Member

cb0s commented Jun 30, 2021

What needs be done:

  • Make private constructor public (or protected ?)
  • Add default values to this very constructor
@cb0s cb0s added 🌷 enhancement New feature or request 👏 help wanted Extra attention is needed telestion 📄 java Pull requests that update Java code labels Jun 30, 2021
@fussel178
Copy link
Member

Well, that's already in. Please see: #298

What we need, is some type of documentation. 🤔

@fussel178 fussel178 added 📚 documentation Improvements or additions to documentation 🔧 telestion-api Everything related to the telestion-api module and removed 👏 help wanted Extra attention is needed labels Jul 21, 2021
@fussel178 fussel178 added this to the v0.9 milestone Jan 31, 2022
@fussel178 fussel178 modified the milestones: v0.9, v0.10 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 📄 java Pull requests that update Java code 🌷 enhancement New feature or request 🔧 telestion-api Everything related to the telestion-api module
Projects
None yet
Development

No branches or pull requests

2 participants