Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest: add sidewalk quest #63

Open
tordans opened this issue Mar 20, 2020 · 1 comment
Open

Quest: add sidewalk quest #63

tordans opened this issue Mar 20, 2020 · 1 comment
Labels
quest suggestion A suggestion for a new quest that should be added to the app

Comments

@tordans
Copy link

tordans commented Mar 20, 2020

https://github.com/westnordost/StreetComplete/tree/master/app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk looks complex but good to use here as well. There is still some to do in Berlin for sidewalk :)

@wtimme
Copy link
Owner

wtimme commented Mar 22, 2020

Nice idea, I like it!

For the quest system in its current state, we need this information:

  • Quest ID: A String that is used to reference the quest's "selected" state in the UserDefaults
  • Question
  • Overpass Wizard Query: A query that the objects on the map are matched against
  • Icon Image
  • Type: As of now, the app supports
    • boolean (yes/no)
    • multiple choice
    • numeric

(I should probably create a GitHub issue template for this.) Done.

Everything can be copied from StreetComplete, except for the Overpass Wizard Query. The query that they are using looks like a full Overpass query, not a Wizard query.

I am not sure how we can get the Overpass Wizard Query from that quest. Since you can compose and test these queries in OSM Completionist already, maybe you can have a look and see if you can come up with one?

Edit: I tried extracting the query from AddSidewalk.kt:

type:way and highway ~ '^(primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential)$' and area != yes and motorroad != yes and (sidewalk !=* and sidewalk:left != * and sidewalk:right != * and sidewalk:both != *) and maxspeed !~ '^(8|7|6|5|5 mph|walk)$' and surface !~ '^(unpaved|compacted|gravel|fine_gravel|pebblestone|grass_paver|ground|earth|dirt|grass|sand|mud|ice|salt|snow|woodchips)$' and (lit = yes) and (foot != no) and access !~ '^(private|no)$' and foot != use_sidepath

What is missing, though, is its last part: In the comment, it states that

some roads may be farther than minDistToWays from ways, not tagged with footway=separate/sidepath but may have a hint that there is a separately tagged sidewalk

In its current form, our Overpass Turbo Wizard quests are not able to handle this, since they only work with the Wizard query; not with raw ones.
Could you try the query and see how it works for you?

@wtimme wtimme added the quest suggestion A suggestion for a new quest that should be added to the app label Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quest suggestion A suggestion for a new quest that should be added to the app
Projects
None yet
Development

No branches or pull requests

2 participants