Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent Screen Not Displayed When Enabling FIDO Trusted App Feature after enable the consent explicitly #21622

Open
aaujayasena opened this issue Nov 6, 2024 · 3 comments

Comments

@aaujayasena
Copy link
Contributor

aaujayasena commented Nov 6, 2024

Describe the issue:

Consent Screen Not Displayed When Enabling FIDO Trusted App Feature and following error can be observed.
"Update error
Invalid application configuration for application: 'mobapp' of tenantDomain: carbon.super. Trusted app feature is enabled without data. Consent should be granted for trusted apps if FIDO trusted app feature is enable"
Screenshot from 2024-11-06 10-42-30

Doc: https://is.docs.wso2.com/en/next/guides/authentication/passwordless-login/add-passwordless-login-with-passkey/#make-application-a-fido-trusted-app

How to reproduce:

  1. Add toml change before starting the server,

[application_mgt]
trusted_app_consent_required=true

  1. Log into console and create a mobile application.
  2. Edit the created application and go to the Advanced tab.
  3. Under Trusted App Settings, tick the Add as a FIDO trusted app checkbox.

Expected behavior:
A popup will appear asking for consent, then tick the check box and click on Confirm.

Environment information (Please complete the following information; remove any unnecessary fields) :

  • Product Version: IS 7.1.0-m4
  • OS: Ubuntu 22.04
  • Database: Oracle 19c, H2
  • Userstore: JDBC

Optional Fields

Related issues:
#20487

Suggested labels:

@nilasini
Copy link
Contributor

nilasini commented Nov 6, 2024

According to the code [1] we have to enable the consent explicitly. Didn't we mention it in the feature doc? Could you please verify?

[1] https://github.com/wso2/identity-apps/pull/6570/files

@aaujayasena
Copy link
Contributor Author

According to the code [1] we have to enable the consent explicitly. Didn't we mention it in the feature doc? Could you please verify?

[1] https://github.com/wso2/identity-apps/pull/6570/files
Server level changes has been added,
[application_mgt]
trusted_app_consent_required=true

@aaujayasena aaujayasena changed the title Consent Screen Not Displayed When Enabling FIDO Trusted App Feature Consent Screen Not Displayed When Enabling FIDO Trusted App Feature after enable the consent explicitly Nov 6, 2024
@ImalshaG
Copy link
Contributor

ImalshaG commented Nov 6, 2024

This issue happens when we enable fido trusted app feature in an application and then add the deployment.toml config and restart the server.

The consent prompting will work correctly if we try to enable the trusted app feature when it is not already enabled. But if it was already enabled before changing the deployment.toml config, then we would face this issue. If we disable the feature and enable it again, the consent prompting will work as intended.

We need to improve the handling of this scenario from the UI where consent prompting config will be enabled at mid deployment or else we need to add the instructions to the docs about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants