Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] - Improvements related to react-icons #101

Open
9 tasks
savindi7 opened this issue Apr 6, 2023 · 0 comments
Open
9 tasks

[Design] - Improvements related to react-icons #101

savindi7 opened this issue Apr 6, 2023 · 0 comments
Assignees
Labels
Type/Design For design tasks related to Oxygen

Comments

@savindi7
Copy link
Contributor

savindi7 commented Apr 6, 2023

The following improvements are required for the react-icons library

  • All icons should have one size (Preferably 16 x 16 and the view box should be 0 0 16 16)
  • Icons must have fill and strokes must be removed. It is difficult to add styling when icons are styles with a mix of both (refer Choreo icons)
  • Have a compound, single path to simplify icons (E.g. - fontawesome icons)
  • Must have a consistent stroke width
  • Must have a consistent color
  • Must have generic icon names and renamed similar to -> check-circle-16
  • Should not use style attribute
  • Should be pure SVGs.
  • Re-check if all icons in the design is available in the icon library
  • E.g. - Check circle icon is missing
@savindi7 savindi7 added the Type/Design For design tasks related to Oxygen label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Design For design tasks related to Oxygen
Projects
None yet
Development

No branches or pull requests

2 participants