Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade views_arg_order_sort #358

Open
4 tasks done
mariacha opened this issue Feb 25, 2025 · 1 comment
Open
4 tasks done

Upgrade views_arg_order_sort #358

mariacha opened this issue Feb 25, 2025 · 1 comment
Assignees

Comments

@mariacha
Copy link
Collaborator

mariacha commented Feb 25, 2025

There's a patch for the issue that caused us to use a custom version of this module.
https://www.drupal.org/project/views_arg_order_sort/issues/3212018

The custom version being used is locked at a specific hash:
https://github.com/wri/wri_sites/blob/main/composer.json#L12

If that patch works, we can go back to using released versions of the module.

Update: The patch half worked, but the views associated with this plugin need to be updated to fully work. That work appears below.

Dev tasks:

  • Start from branch issue-358, which has a PR here: https://github.com/wri/wriflagship/pull/1279
  • Look through the config folder for any view that has table: views_arg_order_sort. Within that view, find a 'null' argument, and replace it with the 'nid' argument (see examples in views where this is already done).
  • Move these config changes back to the install profile's config/install folders.
  • Add an update hook that applies the changes to the "null" arguments, replacing them with the "nid" argument. You can put that update hook in the wri_common module.
mariacha pushed a commit that referenced this issue Feb 27, 2025
@mariacha mariacha self-assigned this Feb 27, 2025
@mariacha mariacha assigned mariacha and unclegcb and unassigned mariacha and unclegcb Mar 10, 2025
@unclegcb
Copy link

unclegcb commented Mar 12, 2025

  • views.view.3_1 -- in existing PR
  • views.view.featured_tweet -- No arguments exist? (arguments: { })
  • views.view.happening_now -- in existing PR
  • views.view.homepage_projects -- in existing PR
  • views.view.superfeatured_content -- in existing PR
  • views.view.trending_topics -- no null arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants