-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for new PLOS license statement #121
Comments
I am wondering if the cause of this problem is the "4.0", and that CC just came out with this recently. For forwards-compatibility, you might consider making the software match not care about the version number. I.e., any license of the form |
The problem is not the 4.0 license (which has been used by PLOS since mid-December) but the inclusion of the xlink statement into the license tag (which was introduced earlier this month). Not sure that is proper JATS (may well be), but in any case, it leads to all PLOS stuff now being labeled as licensed "None". |
I checked again, and in fact, this is contrary to the PMC tagging guidelines. Here's the new PLOS tagging, again, indented: <license xlink:href="http://creativecommons.org/licenses/by/4.0/">
<license-p>This is an open-access article distributed under the terms of the
<ext-link ext-link-type="uri"
xlink:href="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution
License</ext-link>, which permits unrestricted use, distribution, and reproduction in
any medium, provided the original author and source are credited.
</license-p>
</license> And here is what the PMC tagging guidelines have to say (here):
|
Any idea why the validation at PMC does not pick that up? |
Hi, I just checked. Apparently (I didn't know this) these are "just guidelines", and the stylechecker doesn't have checks for everything that is called out here. Probably the best thing to do is to fix the OAMI to handle this. It should always prefer the URI in the license/@xLink:href attribute, if it is present. |
Some more examples for testing: |
Issue fixed with 32fcabc. |
Similar issue is in #124 . |
PLOS have recently changed from
(example: http://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=pmc&id=PMC3919755 )
to
(example: http://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=pmc&id=PMC3913557 ).
I think
https://github.com/erlehmann/open-access-media-importer/blob/master/sources/pmc.py#L490
to
https://github.com/erlehmann/open-access-media-importer/blob/master/sources/pmc.py#L500
has to be adapted accordingly.
Currently, these new license statements are interpreted as None.
The text was updated successfully, but these errors were encountered: