Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citations to use citation-wpoa template #40

Open
Klortho opened this issue Sep 7, 2014 · 6 comments
Open

Fix citations to use citation-wpoa template #40

Klortho opened this issue Sep 7, 2014 · 6 comments

Comments

@Klortho
Copy link
Member

Klortho commented Sep 7, 2014

@Daniel-Mietchen and @notconfusing and I got started on this.

In the XSLT, I've changed the template that's invoked from "citation" to "citation-wpoa".

We'll create this new Template:Citation-wpoa, and it will basically be a proxy for Template:Citation/core.

Next, I'm changing the parameter names and some of the logic in the XSLT to match the parameters used by Citation/core.

For testing, you can use these sandbox copies of the templates:

@Klortho
Copy link
Member Author

Klortho commented Sep 27, 2014

Wherever possible, when necessary to override and use different parameter names than those used in Citation/core, we should look first at Cite_journal, and see if those parameters make sense, and then copy-paste the code from there.

@Klortho
Copy link
Member Author

Klortho commented Sep 27, 2014

Example article:

Problems:

  • (minor) - Year is not showing up
  • ✗ (major) - 5th reference ("Pruis MJ"): DOI is not showing up. Not a problem we can fix in XSLT, since this DOI is showing up in a comment tag.
  • Fix citation ranges #49 (major) - Number of citations is different: wikisource has 39; PMC has 44.
  • Fix citation ranges #49 (major) - In-text citation range in PMC, in the introduction, is "[2]-[4]". In Wikisource, this is translated as "[2]-[3]" for some reason.

@Klortho
Copy link
Member Author

Klortho commented Sep 27, 2014

Problem: Year is not showing up.

@Daniel-Mietchen
Copy link
Member

@wrought can you try to help getting the years to show up in the HTML? Somehow, the core template swallows it.

@notconfusing
Copy link
Member

i made a fall-back on to using the {{{section}}} parameter in the mean-time to workaround the single quote artefact.

@Daniel-Mietchen
Copy link
Member

@notconfusing that was in the header template, whereas this thread is about the citation templates.

@tcatapano tcatapano added the ready label Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants