-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix revert coreimage block width type #340
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 18d9e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Latest Image block.json width is of type "string" so I don' think this is a breaking change https://github.com/WordPress/WordPress/blob/master/wp-includes/blocks/image/block.json#L74 |
Co-authored-by: Colin Murphy <[email protected]>
@theodesp LTGM |
Yes it is... |
Yes. I've seen this. The thing is, I don't see where this Also after trying to query the Schema with this PR with WP v6.7.1, I can see the type is string: ![]() Is it the |
My understanding of your CI, is that you're defining the WordPress version in the .env.dist instead of in the CI itself, so makes sense it would get out dated, but that's not the issue here. The issue is that the minimum WP requirement isn't 6.7, and as such removing this is a breaking change for users on earlier versions of WordPress. (Personally, I'd much rather break this just once as part of #136 / interfaces that stabilize the schema independently underlying changes to WordPress ) |
@justlevine Thanks I will just increase the major version with a note. |
Reverts #130