Plugin throwing an error when WP GraphQL is disabled

[colinmurphy]

As reported by @justlevine

Steps to replicate

If you disable WP GraphQL while WP GraphQL Content Blocks is enabled, you will get a fatal error.

[colinmurphy]

@justlevine

I was able to replicate the issue locally.

So updating the library blakewilson/wp-enforce-semver to version 3 fixed the issue.

But also I don't think WP GraphQL Content Blocks should be loaded without WP GraphQL

So we could add something like this into the plugin description

 * Requires Plugins: wp-graphql

What do you think?

[justlevine]

@justlevine

But also I don't think WP GraphQL Content Blocks should be loaded without WP GraphQL

So we could add something like this into the plugin description

 * Requires Plugins: wp-graphql

What do you think?

I said it was a bad idea before y'all already implemented it in #332 🤷

Either way, requires plugins is a UX solution not a code one, (e.g. renaming the wp-graphql plugin folder, wp plugin deactivate --force, or simply a race condition when bulk activating/deactivating wp-graphql and wp-graphql-content-blocks together ).

If you're looking for a better long term solve I'd investigate replacing that semver library with what we now ship in WPGraphQL core - it probably needs some options exposed in core, but an internal goal is to make it easy for any extension to opt into WPGraphQL's semver for their own checking/updates.

[colinmurphy]

Thanks @justlevine

Ah sorry you did point out about issues with requiring the plugin and that's a good point about the UX/code solution.

I definitely think we should look into longer term fix and seeing how we can integrate into core as it would make sense to me as this is a WP GraphQL extension that we would use the same service for SemVer as WP GraphQL. Thanks for sharing this as well 👍

[theodesp]

@colinmurphy can we just update

"blakewilson/wp-enforce-semver": "^3.0.1"

to its latest version?
I think that fixes the issue

[colinmurphy]

Thanks @justlevine

We will look at getting the short term fix implemented this week and add the WP GraphQL Semver part to the backlog to do in the future.