“Link to” attribute not added to shortcode

[montchr]

Tested on a fresh install. Seems the linkto attribute is never added when inserting image into post from media library. If you go back to edit the shortcode in place and hit update, it's only then that the attribute is added.

I've selected link to file:

But this is the output:

[img attachment="15" align="alignnone" size="medium" alt="montchr-electric-factory-20151110-44" /]

[montchr]

I'm thinking that this might have something to do with linkto not being in the array of allowed attributes here.

[goldenapples]

I'm thinking that this might have something to do with linkto not being in the array of allowed attributes here.

I suspect you're right there. I did some hackery in the data-migration script here to convert links to the appropriate linkto value when migrating old images to shortcodes, but I don't think we're picking up anything for that value for newly-inserted images from the media library screen.

Care to put together a pull request to fix it?

[montchr]

Sure, I'll try to put something together this afternoon.

[vralle]

fix by js: https://gist.github.com/vralle/b0db1083f1c8e392527e

and small fix in php for 'filter_media_send_to_editor':

$allowed_attrs = array(
        'image-size' => 'size',
        'image_alt' => 'alt', 
        'post_excerpt' => 'caption',
        // 'width' => 'width',  // not reported by default js
        'linkto' => 'linkto', // not reported by default js
        'url' => 'url'
    );

And link to attachment post reported by js as 'linkto'='post'. now image-shortcake has link to attachment post as 'linkto'='attachment'