Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change terminology borehole depth/length #317

Closed
wouterpeere opened this issue Jan 17, 2025 · 1 comment
Closed

Change terminology borehole depth/length #317

wouterpeere opened this issue Jan 17, 2025 · 1 comment
Assignees
Milestone

Comments

@wouterpeere
Copy link
Owner

Currently, the property 'self.H' is used as the borehole length, but it is referred to as the borehole depth, which is another concept.
This issue has the goal of redefining the terminology, using self.H as the borehole length (as it is know) and defining another parameter 'self.depth' that is the actual depth of the deepest point in the borefield.

@wouterpeere wouterpeere self-assigned this Jan 17, 2025
@wouterpeere wouterpeere moved this to 🆕 New in GHEtool development Jan 17, 2025
@wouterpeere wouterpeere linked a pull request Jan 17, 2025 that will close this issue
@wouterpeere wouterpeere added this to the 2.3.1 milestone Jan 17, 2025
@wouterpeere wouterpeere moved this from 🆕 New to 🏗 In progress in GHEtool development Jan 17, 2025
@wouterpeere
Copy link
Owner Author

In this issue, there is also improvement in the accuracy of temperature calculation with multiple ground layers and in sizing for all cases.

Currently, there was the assumptie for the temperature calculation that the average temperature was taken at depth H (with H the borehole length). For 99% of cases, this is correct, but if you drill under a building, the buried depth can become relevant for the average temperature. Therefore, all the temperature calculations of the ground will now take into account the buried depth as well.

For the calculation of the ground thermal conductivity and ground volumetric heat capacity the same reasoning is applied, where now the buried depth is taken into account.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in GHEtool development Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant