Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed translations #110

Open
Joni-Aaltonen opened this issue Jun 25, 2018 · 2 comments
Open

Changed translations #110

Joni-Aaltonen opened this issue Jun 25, 2018 · 2 comments
Assignees

Comments

@Joni-Aaltonen
Copy link
Contributor

@ailtisWSFR

There are some new translations that I've added to the translations file.

I'm not quite sure how you normally handle translations. Please let me know if you'd like me to add the new translations here as comments, or if you are able to edit the file yourself.

The new ones in fr.json file are in english, so it's easy to recognize what has changed.

@Joni-Aaltonen
Copy link
Contributor Author

The new translations are in branch feature/#85 and are related to the new view for adding supplied item fields for recommendations

https://github.com/worldskills/worldskills-infrastructure-list/blob/feature/%2385/app/languages/fr.json

@ailtisWSFR
Copy link

@Joni-Aaltonen
I'm sorry but I've never done a translation on this project so I do not know how to proceed.
I think it would be easier for me if you could just put the translations wanted as comments here tagging me on so I can respond to the comments with the correct French translation.
If that's working for you, perfect. If not, please give me more directions about what to do, where to find the information and how to implement the traduction.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants