Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaskDeadlineDrawer #1166

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Add TaskDeadlineDrawer #1166

merged 4 commits into from
Jan 11, 2025

Conversation

hemangsk
Copy link
Contributor

@hemangsk hemangsk commented Jan 9, 2025

Closes #1132

Description

Created a new TaskDeadlineDrawer component to handle task deadline functionality in a consistent drawer pattern, matching the design of OfferDrawer and PaymentDrawer components. Fixed issues with date display and alignment.

Purpose

  • Move the deadline form into a drawer component for better UI consistency
  • Fix date display issues where existing dates weren't showing up
  • Improve the UI/UX of the deadline form with better button states and alignment
  • Add clear date functionality

Solution

  1. Created new TaskDeadlineDrawer component
  2. Updated TaskDeadlineForm with:
    • Fixed date initialisation from props
    • Added dateChanged state to control button text
    • Improved date field and label alignment
    • Added clear date functionality
  3. Updated Task component to use new drawer

Screenshots

Screenshot 2025-01-09 at 2 22 44 PM

Checklist

  • Code has been tested and works as intended
  • Properly documented code
  • Follows coding standards and guidelines
  • All tests pass
  • No conflicts with current codebase
  • Code has been reviewed by at least one other team member

@dosubot dosubot bot added the enhancement label Jan 9, 2025
Copy link

codeautopilot bot commented Jan 9, 2025

PR summary

This Pull Request introduces a new TaskDeadlineDrawer component to enhance the user interface and experience by adopting a consistent drawer pattern for managing task deadlines. The changes aim to align the task deadline functionality with existing components like OfferDrawer and PaymentDrawer. Key improvements include fixing date display issues, enhancing button states and alignment, and adding a clear date functionality. The TaskDeadlineForm has been updated to initialize dates correctly, manage state changes more effectively, and improve styling. The Task component has been modified to utilize the new drawer component.

Suggestion

To further enhance the user experience, consider adding unit tests for the new TaskDeadlineDrawer component to ensure its functionality is robust and to prevent future regressions. Additionally, ensure that all translations are complete and accurate across different languages to maintain consistency in user communication.

Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect.

Current plan usage: 2.45%

Have feedback or need help?
Discord
Documentation
[email protected]

@alexanmtz alexanmtz merged commit 501756f into worknenjoy:master Jan 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadline in the issue page revisited
2 participants