Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress v5: Investigate cases where app markup differs to the web #6682

Open
SiobhyB opened this issue Feb 28, 2024 · 0 comments
Open

VideoPress v5: Investigate cases where app markup differs to the web #6682

SiobhyB opened this issue Feb 28, 2024 · 0 comments
Labels
Jetpack Bug or feature related to Jetpack [Type] Enhancement Improves a current area of the editor Video block

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 28, 2024

There are some cases where the markup produced in the app differs to the web.

For example, on the web, the videoPressClassNames and title attributes are added to the block's markup for the following site types:

Site Type videoPressClassNames title
Simple
Atomic w/VideoPress
Atomic w/no VideoPress
Jetpack w/VideoPress
Jetpack w/no VideoPress

The videoPressClassNames and title attributes are never added to the markup in the app.

In addition, there is an edge case, as described here, where manually adding a videos.files.wordpress.com/* URL automatically converts to a videopress.com/* URL in the app, but not on the web.

These changes are non-breaking, but would be nice to resolve in order for the markup to always be consistent across platforms.

@SiobhyB SiobhyB added [Type] Enhancement Improves a current area of the editor Jetpack Bug or feature related to Jetpack Video block labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack [Type] Enhancement Improves a current area of the editor Video block
Projects
None yet
Development

No branches or pull requests

1 participant