From eb60471291f85d62eb2fdfaf2e8a33ba28a93f33 Mon Sep 17 00:00:00 2001 From: HyungHoKim00 Date: Thu, 19 Dec 2024 11:05:19 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20toString=20=EC=9E=AC=EC=A0=95?= =?UTF-8?q?=EC=9D=98=20=EB=B0=8F=20=EA=B2=80=EC=A6=9D=20=EB=A1=9C=EC=A7=81?= =?UTF-8?q?=20=EB=B6=84=EB=A6=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/cruru/applicant/domain/Evaluation.java | 13 +++++++++++++ .../cruru/applicant/service/EvaluationService.java | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java b/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java index a8860b7c..0d41c1e4 100644 --- a/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java +++ b/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java @@ -66,6 +66,18 @@ private boolean isOutOfRange(int score) { return score < MIN_SCORE || score > MAX_SCORE; } + public boolean isEvaluator(String evaluator) { + return this.evaluator.equals(evaluator); + } + + public boolean isContent(String content) { + return this.content.equals(content); + } + + public boolean isScore(int score) { + return this.score == score; + } + @Override public boolean isAuthorizedBy(Member member) { return process.isAuthorizedBy(member); @@ -92,6 +104,7 @@ public int hashCode() { public String toString() { return "Evaluation{" + "id=" + id + + ", evaluator='" + evaluator + '\'' + ", score=" + score + ", content='" + content + '\'' + ", process=" + process + diff --git a/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java b/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java index b135ebc6..e54455c5 100644 --- a/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java +++ b/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java @@ -57,9 +57,9 @@ public void update(EvaluationUpdateRequest request, Evaluation evaluation) { private boolean changeExists(EvaluationUpdateRequest request, Evaluation evaluation) { return !( - evaluation.getContent().equals(request.content()) - && evaluation.getScore().equals(request.score()) - && evaluation.getEvaluator().equals(request.evaluator()) + evaluation.isContent(request.content()) + && evaluation.isScore(request.score()) + && evaluation.isEvaluator(request.evaluator()) ); }