Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Investigate if we can remove wp-block-editor from the All Products block dependencies #4543

Closed
Aljullu opened this issue Aug 4, 2021 · 8 comments
Closed

Investigate if we can remove wp-block-editor from the All Products block dependencies #4543

Aljullu opened this issue Aug 4, 2021 · 8 comments
Labels
block: all products Issues related to the all products block. focus: performance The issue/PR is related to performance. type: bug The issue/PR concerns a confirmed bug. type: cooldown Things that are queued for a cooldown period (assists with planning). type: refactor The issue/PR is related to refactoring.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Aug 4, 2021

The All Products block has wp-block-editor as a dependency. This issue is about investigating if it can be removed and eventually removing it if possible.

I could track down the dependency being imported in these two files:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/19d29d11fea059650da48cbca4f35275e88324d6/assets/js/atomic/blocks/product-elements/price/block.js#L12

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/19d29d11fea059650da48cbca4f35275e88324d6/assets/js/atomic/blocks/product-elements/title/block.js#L10
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: performance The issue/PR is related to performance. type: cooldown Things that are queued for a cooldown period (assists with planning). block: all products Issues related to the all products block. labels Aug 4, 2021
@nielslange nielslange added the type: refactor The issue/PR is related to refactoring. label Aug 4, 2021
@Aljullu
Copy link
Contributor Author

Aljullu commented Sep 15, 2021

I think we would be able to remove those imports if we migrated Product Price and Product Title blocks to use global styles.

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 15, 2021
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 15, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 15, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 17, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 19, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 7, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 7, 2022
@Aljullu Aljullu mentioned this issue Jun 9, 2022
Closed
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 10, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented Aug 22, 2022

Reopening because all-products-frontend.asset.php still lists wp-block-editor as a dependency.

@Aljullu Aljullu reopened this Aug 22, 2022
@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 23, 2022
@gigitux
Copy link
Contributor

gigitux commented May 22, 2023

This bug had been resolved in this PR: #9251. The solution was to #8071.

@gigitux gigitux closed this as completed May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: all products Issues related to the all products block. focus: performance The issue/PR is related to performance. type: bug The issue/PR concerns a confirmed bug. type: cooldown Things that are queued for a cooldown period (assists with planning). type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nielslange @Aljullu @gigitux