Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Decide which CSS custom properties will make sense for the Block Styling System #2460

Closed
Aljullu opened this issue May 11, 2020 · 8 comments
Closed
Labels
focus: global styles Issues that involve styles/css/layout structure. status: stale Stale issues and PRs have had no updates for 60 days.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 11, 2020

We are planning to support the new Gutenberg Block Styling System (see #2403). In phase 3, we will register some CSS custom properties so themes and users can hook up with our blocks and style them without the need to write CSS selectors.

We should discuss which CSS custom properties to create with designers and have a plan for them.

See @nerrad's and @haszari thoughts on this:

#2403 (comment)

  • With css variable naming, I think we should try to avoid being too specific with variables (eg --wp-gs-wc-block-order-summary-item--border--color). To bring consistency we should identify common shared elements across all the ui/ux and name variables according to those elements, so for example the above example might become something like --wp-gs-wc-block-panel--border--color. The more specific we get in variable names, the harder it is to maintain consistency across the design of the blocks. This is where you can likely align with some of the work being done this sprint in finding those inconsistencies and fixing them.

#2403 (comment)

I agree - we should strive to name our colours/variables with high-level semantic names as much as possible.

@nerrad nerrad added the focus: global styles Issues that involve styles/css/layout structure. label Jun 20, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 19, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 21, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 25, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 25, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 4, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 19, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 20, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented Jan 23, 2022

I don't think there is anything actionable related to this. Closing in favor of #5267, where we are working on adding global styles to WooCommerce blocks.

@Aljullu Aljullu closed this as completed Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: global styles Issues that involve styles/css/layout structure. status: stale Stale issues and PRs have had no updates for 60 days.
Projects
None yet
Development

No branches or pull requests

2 participants