Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Create Select component #1573

Closed
Aljullu opened this issue Jan 15, 2020 · 3 comments
Closed

Create Select component #1573

Aljullu opened this issue Jan 15, 2020 · 3 comments
Assignees
Labels
type: enhancement The issue is a request for an enhancement.
Milestone

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 15, 2020

Part of #1348.

We need an <select> field component that can be used in different forms included in the Checkout and Cart block.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Aljullu Aljullu removed their assignment Jan 15, 2020
@senadir
Copy link
Member

senadir commented Jan 15, 2020

Depending on the design requirements, does it make sense to build a custom select box or use the native select experience, the best option, if we want to go custom, is the custom select in Gutenberg, but I believe our case doesn’t require a custom select box, so the native select component should be fine

@nerrad nerrad added type: enhancement The issue is a request for an enhancement. and removed type: feature request labels Jan 24, 2020
@nerrad nerrad added this to the Future Release milestone Jan 27, 2020
@Aljullu Aljullu self-assigned this Feb 21, 2020
@Aljullu
Copy link
Contributor Author

Aljullu commented Feb 21, 2020

That was fixed in #1727 (commit: c48dea2).

@Aljullu Aljullu closed this as completed Feb 21, 2020
@nerrad nerrad modified the milestones: Future Release, 2.6.0 Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants