Improve logic of the function

hichamboushaba · hichamboushaba · commit 328f85127b18 · 2024-09-13T10:55:39.000+01:00
Previously, we were assigning the charts value to itself, and it was making the logic harder to follow.
diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/stats/DashboardStatsView.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/stats/DashboardStatsView.kt
@@ -649,8 +649,7 @@ class DashboardStatsView @JvmOverloads constructor(
     }
 
     private fun generateLineDataSet(revenueStats: Map<String, Double>): LineDataSet {
-        chartRevenueStats = revenueStats
-        val entries = chartRevenueStats.values.mapIndexed { index, value ->
+        val entries = revenueStats.values.mapIndexed { index, value ->
             Entry((index + 1).toFloat(), value.toFloat())
         }
         return LineDataSet(entries, "")

Original file line number	Diff line number	Diff line change
`@@ -649,8 +649,7 @@ class DashboardStatsView @JvmOverloads constructor(`
`649`	`649`	`}`
`650`	`650`
`651`	`651`	`private fun generateLineDataSet(revenueStats: Map<String, Double>): LineDataSet {`
`652`		`- chartRevenueStats = revenueStats`
`653`		`- val entries = chartRevenueStats.values.mapIndexed { index, value ->`
	`652`	`+ val entries = revenueStats.values.mapIndexed { index, value ->`
`654`	`653`	`Entry((index + 1).toFloat(), value.toFloat())`
`655`	`654`	`}`
`656`	`655`	`return LineDataSet(entries, "")`