Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay conflicts with eglot #82

Open
hmelman opened this issue Apr 20, 2022 · 4 comments
Open

Overlay conflicts with eglot #82

hmelman opened this issue Apr 20, 2022 · 4 comments

Comments

@hmelman
Copy link

hmelman commented Apr 20, 2022

I'm using (trying out) eglot with python-mode and it highlights the symbol-at-point with an overlay. I used symbol-overlay-put and other occurrences of the symbol highlighted (more clearly), but the keymap symbol-overlay installs didn't work. If I typed n the character was just inserted (eglot's overlay had a modification-hooks property if that matters), it didn't run symbol-overlay-jump-next.

I assumed it was because of conflicting overlays and added a 'priority 100 to the symbol-overlay overlay and it worked great. I don't know as there's a good solution (there was also a flymake overlay at point) but I think it would help if symbol-overlay included a priority in the overlays it uses and gives the user a symbol-overlay-priority user option to customize. That way we could resolve whatever conflicts we come across.

@uqix
Copy link

uqix commented Jul 27, 2023

@hmelman found any workaround? this's kind of annoying.

purcell added a commit that referenced this issue Jul 27, 2023
@purcell
Copy link
Collaborator

purcell commented Jul 27, 2023

I think it would help if symbol-overlay included a priority in the overlays it uses and gives the user a symbol-overlay-priority user option to customize.

I pushed a quick change to add this. 🤝

@TxGVNN
Copy link

TxGVNN commented Sep 26, 2023

Perfect! This feature has changed my life. 😆

(setq symbol-overlay-priority 100)

@hmelman
Copy link
Author

hmelman commented Sep 26, 2023

It's working well for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants