Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coroutine.h file not found #7928

Open
1 task done
OskarEichler opened this issue Oct 23, 2024 · 7 comments
Open
1 task done

Coroutine.h file not found #7928

OskarEichler opened this issue Oct 23, 2024 · 7 comments

Comments

@OskarEichler
Copy link

What happened?

After upgrading React Native from 0.73.6 to 0.76.0 we are getting the following error:
'folly/experimental/coro/Coroutine.h' file not found

We are on the latest version of react-native-navigation.

We also already tried to add "-DFOLLY_CFG_NO_COROUTINES=1" to the project.pbjproj file.

Please advice.

What was the expected behaviour?

No response

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

Screenshot 2024-10-24 at 07 32 04

In what environment did this happen?

React Native Navigation version: 7.40.3
React Native version: 0.76.0
Has Fabric (React Native's new rendering system) enabled: No
Node version: v20.16.0
Device model: iPhone 16 Pro
iOS version: 18.0.1

@nezort11
Copy link

same for React-jsi

image

@nezort11
Copy link

Adding -DFOLLY_CFG_NO_COROUTINES=1 to the project.pbjproj file also didn't solve issue for me .

This solution works for me: facebook/folly#2297 (comment)

@OskarEichler
Copy link
Author

Adding this to Podfile is patching the issue for the time being:

  post_install do |installer|
    system("chmod -R u+w Pods/RCT-Folly")
    Dir.glob("Pods/RCT-Folly/folly/Portability.h").each do |file|
      text = File.read(file)
      new_contents = text.gsub('#define FOLLY_HAS_COROUTINES 1', '#define FOLLY_HAS_COROUTINES 0')
      File.open(file, "w") { |file| file.puts new_contents }
    end
  end

However still running into this issue (#7920) when trying to build on 0.76.1

@MohamedAbdElNaby
Copy link

hi @OskarEichler , I wanted to see if the iOS issue has been resolved. Could you confirm?

@OskarEichler
Copy link
Author

OskarEichler commented Nov 6, 2024

hi @OskarEichler , I wanted to see if the iOS issue has been resolved. Could you confirm?

The patch I posted in the Podfile is resolving this particular issue, however #7920 is still blocking us from being able to upgrade to 0.76.X

@MohamedAbdElNaby
Copy link

@OskarEichler
can you share with me your podfile please ?

@OskarEichler
Copy link
Author

No sorry - please try to implement the patch I posted above, the run pod install - should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants