We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm attaching two screenshots, first is same js code working well on RNN v7.35.2 and second is the buggy one in latest v7.37.0.
I assume the expected behavior should be the one working well, as on every previous RNN version. This issue is only a bug on iOS, android works fine.
Navigation.mergeOptions(this.props.componentId, { topBar: { title: { text: "Some text", }, rightButtons: [ { id: CustomButtonComponent.TAG, component: { name: CustomButtonComponent.TAG, passProps: { text: "Button text", }, }, }, ], rightButtonColor: 'white', }, });
And the corresponding CustomButtonComponent:
CustomButtonComponent
import React from 'react'; import BaseComponent from '../screens/BaseComponent'; import {StyleSheet, Text, View, TouchableOpacity} from 'react-native'; interface CustomButtonComponentProps { text?: string; } interface CustomButtonComponentState {} export default class CustomButtonComponent extends BaseComponent<CustomButtonComponentProps, CustomButtonComponentState> { static readonly TAG: string = 'CustomButtonComponent'; render() { return ( <TouchableOpacity style={styles.container}> <View style={styles.content}> <Text style={styles.text}>{this.props.text}</Text> </View> </TouchableOpacity> ); } } const styles = StyleSheet.create({ container: { flex: 1, borderRadius: 4, backgroundColor: 'blue', paddingVertical: 6, paddingHorizontal: 10, marginEnd: 8, }, content: {flex: 1, flexDirection: 'row', alignItems: 'center'}, text: {marginStart: 8, fontSize: 20, fontWeight: '500', color: 'white'}, });
React Native Navigation version: 0.37.0 React Native version: 0.72.5 Has Fabric (React Native's new rendering system) enabled: no Node version: 18 Device model: tested on iPhone 11 (but happens on all ios devices afaik) iOS version: tested on 16.4 (but happens on all ios versions afaik)
The text was updated successfully, but these errors were encountered:
Fixed in latest 7.37.1! Thanks a lot @yogevbd !
Sorry, something went wrong.
No branches or pull requests
What happened?
I'm attaching two screenshots, first is same js code working well on RNN v7.35.2 and second is the buggy one in latest v7.37.0.
What was the expected behaviour?
I assume the expected behavior should be the one working well, as on every previous RNN version. This issue is only a bug on iOS, android works fine.
Was it tested on latest react-native-navigation?
Help us reproduce this issue!
And the corresponding
CustomButtonComponent
:In what environment did this happen?
React Native Navigation version: 0.37.0
React Native version: 0.72.5
Has Fabric (React Native's new rendering system) enabled: no
Node version: 18
Device model: tested on iPhone 11 (but happens on all ios devices afaik)
iOS version: tested on 16.4 (but happens on all ios versions afaik)
The text was updated successfully, but these errors were encountered: