Skip to content

Commit 6bfcf16

Browse files
committed
fix: Tab index out of number of tabs range
1 parent 6e7e8f6 commit 6bfcf16

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,11 @@ public void selectTab(final int newIndex) {
269269
}
270270

271271
private void selectTab(int newIndex, boolean enableSelectionHistory) {
272-
saveTabSelection(newIndex, enableSelectionHistory);
273-
tabsAttacher.onTabSelected(tabs.get(newIndex));
272+
final int nextIndex = Math.max(0, Math.min(newIndex, tabs.size() - 1));
273+
saveTabSelection(nextIndex, enableSelectionHistory);
274+
tabsAttacher.onTabSelected(tabs.get(nextIndex));
274275
getCurrentView().setVisibility(View.INVISIBLE);
275-
bottomTabs.setCurrentItem(newIndex, false);
276+
bottomTabs.setCurrentItem(nextIndex, false);
276277
getCurrentView().setVisibility(View.VISIBLE);
277278
getCurrentChild().onViewWillAppear();
278279
getCurrentChild().onViewDidAppear();

0 commit comments

Comments
 (0)