Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the hyperlink for setting-up-the-dev-environment.md #4600

Closed
wants to merge 4 commits into from

Conversation

kagrawal98
Copy link

Description

Updated the link to the introductory environment setup guide in the contributing documentation. The new link points to ../../introduction/environment-setup.md instead of the previous location.

Motivation

This change ensures that contributors are directed to the correct and most up-to-date environment setup guide. Having the correct link is crucial for new contributors to properly set up their development environment before diving into Detox development.

Impact

This update improves the onboarding experience for new contributors by providing them with the correct resource for initial setup. It helps prevent confusion and ensures that all contributors start with a properly configured environment.


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@@ -4,7 +4,7 @@ This document guides you through setting up your development environment to star

:::important Prerequisites

Please complete our [Introductory environment setup](introduction/environment-setup.md) guide before proceeding. This ensures you have the necessary tools and dependencies installed in order to _run_ Detox tests, which is a fundamental step before being able to contribute to the project itself.
Please complete our [Introductory environment setup](../../introduction/environment-setup.md) guide before proceeding. This ensures you have the necessary tools and dependencies installed in order to _run_ Detox tests, which is a fundamental step before being able to contribute to the project itself.
Copy link
Contributor

@asafkorem asafkorem Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. What was broken? The link works (see the "Prerequisites" admonition)
https://wix.github.io/Detox/docs/contributing/code/setting-up-the-dev-environment

@asafkorem
Copy link
Contributor

@kagrawal98 The documentation isn't intended to be read directly from the plain MD files (which probably have caused the linking issue you experienced). Please use the official docs site instead: https://wix.github.io/Detox/docs/contributing/code/setting-up-the-dev-environment/

@asafkorem asafkorem closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants