Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add item color assertion #3297

Open
d4vidi opened this issue Apr 5, 2022 · 5 comments
Open

Add item color assertion #3297

d4vidi opened this issue Apr 5, 2022 · 5 comments

Comments

@d4vidi
Copy link
Collaborator

d4vidi commented Apr 5, 2022

Describe your idea

We could theoretically add that the getAttributes(), although, I'd like to take a guess that the RN-side prop doesn't necessarily easily map to the native equivalent (as we've seen in the past).

Nevertheless, this is definitely something we could accept as a feature.

@Skaramus1990
Copy link

@d4vidi Thank you for your quick answer. How about borderColor attribute? Generally in the css styles we can have a lot of attributes for verification.

@d4vidi
Copy link
Collaborator Author

d4vidi commented Aug 17, 2022

If we do this, we are likely to handle everything color-related. That said, CSS and native-mobile are inherently different. We will extract what we can, and cannot guarantee that borderColor and such are accessible.

@Skaramus1990
Copy link

@d4vidi Thank you for your answer. In the future (plans) we will extract all attributes of an element which will appear for it. Am I right?

@d4vidi
Copy link
Collaborator Author

d4vidi commented Aug 18, 2022

I don't have an ETA or anything. This issue has even been marked for contribution...

@dreamyguy
Copy link

dreamyguy commented Apr 23, 2023

I see you do validation based on attributes, and that's ok. But if you see the need to do validation as in knowing if the color is a valid HTML color at all, you can use the validate-color npm package, currently the most feature-rich HTML color validator in town. 🎨 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants