-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Docs update for includeFiles and excludeFiles options on netlify adapter #10760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting these docs for your feature! I've made a few suggestions below to conform to our style and language use. And, I think the examples should all refer to netlify
here and not vercel
, right? 😄
Also, please remove the translation file. We have a process for translation, and our PR template reminds you that you should only make a PR in one language. Thank you for following our system!
I'm looking forward to having this feature in docs!
For Team Docs looking at this PR: this PR highlights that the Netlify and Vercel docs are structured a little differently. (The Vercel documentation lists these as configuration options, whereas the Netlify docs are more "topic based." We can't fix that in this PR, but we may want to eventually move to consistency between the two! 😅
Also noting that the implementation PR changeset includes information that should be in docs itself, so we will need to work this in:
|
…excludeFiles on netlify adapter" This reverts commit 08b5519.
Hey @sarah11918 thanks for the feedback! I've updated the examples to reference Netlify instead of Vercel and removed the translation file as requested. I've also added more information to the docs as requested. Let me know if there's anything else needed 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick note these are in really good shape, and I'm waiting on the implementation PR to be reviewed/approved (just to make sure there's no new info/nothing changes) before doing a final polish here! 🫡
Also noting that now that we've moved the adapters, this shouldn't affect the docs we've got going here, but we will need to update the PR description so we can link to the new PR to the main Astro repo instead of the closed adapters repo PR! 🙌 |
Thanks for updating the description to link to the new Reminder (for all of us) that these docs will then still need final polishing once they are out of draft, when I'll compare to the implementation PR itself, the changeset there etc.! 🙌 |
Important comment made on the implementation PR that we should consider for the docs to 👍 |
@sarah11918 I added the relative code PR to the next release 5.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some polishing changes, including making the additions more like our standard API reference. (I know, this is an older page that hasn't yet been updated in other entries, but let's at least get this one in shape!)
Please do check for accuracy!
Hey @sarah11918 thanks for the feedback again! I have made a commit including all the suggested changes 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the updates, and thanks for also importing that <Since />
component! Welcome to Team Docs! 🥳
Description:
Docs update for withastro/astro#13194.
Note
This PR remains in draft status pending the merge of these options into the adapter. I will mark it as ready for review once the changes are deployed to production.