Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate HMR reloads when using large collections #12751

Closed
1 task
KianNH opened this issue Dec 16, 2024 · 0 comments · Fixed by #12962
Closed
1 task

Duplicate HMR reloads when using large collections #12751

KianNH opened this issue Dec 16, 2024 · 0 comments · Fixed by #12962
Labels
needs triage Issue needs to be triaged

Comments

@KianNH
Copy link

KianNH commented Dec 16, 2024

Astro Info

Astro                    v5.0.7
Node                     v22.12.0
System                   macOS (arm64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @astrojs/mdx

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Using the same reproduction as #12702, following the fix in #12715, HMR is triggered several times upon a single change.

It appears that some reloads are too early, as they will show the old content, and only the later reload will show the new content.

In the below video, the final edit takes ~30 seconds per reload but the first reload shows the same content as before.

Screen.Recording.2024-12-16.at.18.37.28.mp4

What's the expected result?

Only a single reload happens, with the updated content.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-mtk5uaws

Participation

  • I am willing to submit a pull request for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant