Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 19 elements not recognized as React Element #12684

Open
1 task done
jeroenpg opened this issue Dec 8, 2024 · 1 comment · May be fixed by #12685
Open
1 task done

React 19 elements not recognized as React Element #12684

jeroenpg opened this issue Dec 8, 2024 · 1 comment · May be fixed by #12685
Assignees
@jeroenpg
Labels
- P2: nice to have Not breaking anything but nice to have (priority)

Comments

@jeroenpg
Copy link

jeroenpg commented Dec 8, 2024 •
edited
Loading

Astro Info

Astro                    v4.16.16
Node                     v22.11.0
System                   Linux (x64)
Package Manager          yarn
Output                   static
Adapter                  none
Integrations             @astrojs/solid-js
                         @astrojs/react

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

React 19 elements are not recognized since facebook/react#2881 renamed react.element to react.transitional.element. This only occurs when multiple compatible frameworks are found for a single file, for instance when using Solid.js + React simultaneously.

What's the expected result?

To render react elements using React 19

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-ymshvplf?file=src%2Fpages%2Findex.astro

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 8, 2024
@jeroenpg jeroenpg linked a pull request Dec 8, 2024 that will close this issue
Open
@jeroenpg
Copy link
Author

jeroenpg commented Dec 8, 2024

created a pr #12685 to solve this issue.

@ematipico ematipico added the - P2: nice to have Not breaking anything but nice to have (priority) label Dec 11, 2024
@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeroenpg jeroenpg

Labels
- P2: nice to have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adapter recognizes react 19 react.transitional.element jeroenpg/astro
2 participants
@ematipico @jeroenpg