Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context and Error Handling #27

Open
stevenceuppens opened this issue Sep 12, 2023 · 1 comment
Open

Context and Error Handling #27

stevenceuppens opened this issue Sep 12, 2023 · 1 comment
Labels
triage Reviewing issue

Comments

@stevenceuppens
Copy link

Hi Patrick, nice work!

I have your code working, but running into a few missing features:

I need access to the Buf Context for accessing MetaData in the Buf Method handlers
https://connectrpc.com/docs/node/implementing-services#context
Have you foreseen this or should we add this?

I want to use the Buf Error definitions, but they do not map when using them
https://connectrpc.com/docs/node/implementing-services#errors
Have u tested/used them before?

Thanks!
Steven

@stevenceuppens stevenceuppens added the triage Reviewing issue label Sep 12, 2023
@wolfie82
Copy link
Member

Hi @stevenceuppens, I should be circling back around to this project soon as I have a need for it. I don't think it would be too difficult to expose that metadata. I'll have to review the error handling as well, so thank you for bringing this to my attention. If you feel like you want to take a crack at it, I would more than happily accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Reviewing issue
Projects
None yet
Development

No branches or pull requests

2 participants