Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception #14

Open
danclimasevschi opened this issue Oct 29, 2021 · 2 comments
Open

Uncaught exception #14

danclimasevschi opened this issue Oct 29, 2021 · 2 comments

Comments

@danclimasevschi
Copy link

status = wmm.StatusEvent.from_payload(message.payload)

This call might raise a RuntimeError which is not handled.

@GwendalRaoul
Copy link
Contributor

Hello!

Yes you are right.

But it shouldn't never happen. It should happen if the https://github.com/wirepas/backend-apis/blob/master/gateway_to_backend/protocol_buffers_files/config_message.proto#L116 is different than 1.
But since we have defined the protobuf gateway api, we have never break the backward compatibility, so version should be 1 everywhere.
But I realized that this field is poorly documented.

If you faced this issue, I guess you have your own gateway implementation.

But anyway I will add it soon.

Thanks for the bug report.

Gwendal

@danclimasevschi
Copy link
Author

danclimasevschi commented Nov 8, 2021

Hi,
that actually happened when i published an empty payload to gw-event/status/<some gw id> in order to remove the retained configuration of a gateway which was no longer in use.
Thanks,
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants