Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent Lib: Request should upgrade to newer version #71

Open
drawyan opened this issue Aug 16, 2017 · 4 comments
Open

Dependent Lib: Request should upgrade to newer version #71

drawyan opened this issue Aug 16, 2017 · 4 comments

Comments

@drawyan
Copy link

drawyan commented Aug 16, 2017

Problem:
The current dependent lib request version of request": "2.75.x" has an old dependency of aws-sign2: 0.6.0 which has a serious bug of duplicated exporting names: request/aws-sign#7

And this is preventing bundle tools such as rollup to fail because it can't allow duplicated exports from the same module.

@dogboydog
Copy link

dogboydog commented Sep 21, 2017

Another reason to do this: the version of request used uses a vulernable tough-cookie dependency

https://nodesecurity.io/advisories/525

New version is available after this PR closed (salesforce/tough-cookie#92). Please update so nsp check and other security tools can succeed without adding exceptions

@mmukarram
Copy link

mmukarram commented Feb 1, 2018

Yet another reason: the 2.75.x version(s) of request uses a deprecated version of node-uuid which has now been transitioned to uuid. More on this change here: uuidjs/uuid#142

Since there is already a pull request #75 for this, can it be merged?

@GreenGremlin
Copy link

And another...

The current pinned version of the request module has an ancestral dependency on a version of hoek that has a DDOS vulnerability.

Upgrading the request module to any version > 2.84.0 should suffice.

@jimmywarting
Copy link

hoek node module before 5.0.3 or 4.2.1 suffers from a Modification of Assumed-Immutable Data (MAID) vulnerability - updating request will maybe solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants