fookb: Use libdockapp instead of X resource manager for command line options.

Author: d-torrance

fookb/Makefile.am

@@ -1,5 +1,5 @@
 bin_PROGRAMS = fookb
-fookb_SOURCES = fookb.c fookb.h globals.c images.c images.h opts.c opts.h \
+fookb_SOURCES = fookb.c fookb.h images.c images.h opts.h \
 	params.c params.h sound.c sound.h
 dist_man_MANS = fookb.1x
 dist_pkgdata_DATA = 1.xpm 2.xpm 3.xpm 4.xpm rus.xpm lat.xpm boom.xpm \

fookb/fookb.c

@@ -11,9 +11,6 @@
 #include <X11/Xlib.h>
 #include <X11/Xutil.h>
 
-/* Command line parsing and X resource manager */
-#include <X11/Xresource.h>
-
 /* XKB fun */
 #include <X11/XKBlib.h>
 
@@ -25,6 +22,13 @@
 #include "sound.h"
 #include "opts.h"
 
+char *icon1 = NULL;
+char *icon2 = NULL;
+char *icon3 = NULL;
+char *icon4 = NULL;
+char *iconboom = NULL;
+char *display = NULL;
+
 #define sterror(x) (void)printf("Strange error, please report! %s:%d, %s\n",\
 		__FILE__, __LINE__, x)
 
@@ -34,13 +38,33 @@ int main(int argc, register char *argv[])
 	int state = 0;		/* We suppose that latin keyboard is the
 				   primal state FIXME */
 	Pixmap pixmap;
-
-
-	DAParseArguments(argc, argv, NULL, 0,
+	DAProgramOption options[] = {
+		{NULL, "--icon1",
+		 "Icon to show for the 1st Xkb group",
+		 DOString, False, {&icon1}},
+		{NULL, "--icon2",
+		 "Icon to show for the 2nd Xkb group",
+		 DOString, False, {&icon2}},
+		{NULL, "--icon3",
+		 "Icon to show for the 3rd Xkb group",
+		 DOString, False, {&icon3}},
+		{NULL, "--icon4",
+		 "Icon to show for the 4th Xkb group",
+		 DOString, False, {&icon4}},
+		{NULL, "--iconboom",
+		 "Icon to show when Xkb system goes crazy",
+		 DOString, False, {&iconboom}},
+		{"-d", "--display",
+		 "X display to use (normally not needed)",
+		 DOString, False, {&display}},
+	};
+
+
+	DAParseArguments(argc, argv, options, 6,
 			 "XKB state indicator for Window Maker",
 			 PACKAGE_STRING);
 
-	DAOpenDisplay(NULL, argc, argv);
+	DAOpenDisplay(display, argc, argv);
 	read_images(DADisplay);		/* Let's read icon images */
 	DACreateIcon(PACKAGE_NAME, get_width(), get_height(), argc, argv);
 	XSelectInput(DADisplay, DAWindow, ButtonPressMask);

fookb/globals.c

@@ -8,25 +8,6 @@
 #ifndef OPTS_H
 #define OPTS_H
 
-/* X Window resource management */
-#include <X11/Xlib.h>
-#include <X11/Xresource.h>
-extern XrmDatabase cmdlineDB;	/* Database for resources from command
-				   line */
-
-extern XrmDatabase finalDB;	/* Database for resources from other
-				   sources -- app-defaults and X
-				   Window resources */
-
-void ParseOptions(int *argc, register char *argv[]);	/* Parse
-							   command
-							   line
-							   options */
-
-void MoreOptions(Display *dpy);		/* Parse
-				   app-defaults
-				   and X
-				   resources
-				   database */
+extern char *icon1, *icon2, *icon3, *icon4, *iconboom, *display;
 
 #endif				/* OPTS_H */

fookb/opts.c

@@ -2,6 +2,7 @@
 #include <string.h>		/* strlen & strcat */
 #include <ctype.h>		/* toupper */
 #include <stdlib.h>
+#include <WINGs/WUtil.h>
 #include "params.h"
 #include "opts.h"
 
@@ -10,46 +11,24 @@
 
 char *read_param(char *string)
 {
-	XrmValue xvalue;
-
 	WMPropList *pl;
 	WMPropList *value;
 	WMPropList *tmp;
 	char *path;
-	char *newstring;
-	char *newString;
 	char *result;
 
-	/* Let's make lint happy */
-	xvalue.size = 0;
-
-	newstring = wstrconcat("fookb.", string);
-	newString = wstrconcat("Fookb.", string);
-	newstring[6] = tolower((unsigned char)newstring[6]);
-	newString[6] = toupper((unsigned char)newString[6]);
-
 /* Command line parameters take precedence over all */
 
-	if (XrmGetResource(cmdlineDB,
-				newstring,
-				newString,
-				str_type,
-				&xvalue) == True) {
-		result = (char *) malloc(xvalue.size + 1);
-		if (NULL == result) {
-			lputs("Not enough memory");
-			exit(EXIT_FAILURE);
-		}
-		strncpy(result, xvalue.addr, (size_t)xvalue.size);
-		result[(int) xvalue.size + 1] = '\0';
-
-		wfree(newstring);
-		wfree(newString);
-		return result;
-	}
-
-	wfree(newstring);
-	wfree(newString);
+	if (!strcmp(string, "Icon1") && icon1)
+		return icon1;
+	if (!strcmp(string, "Icon2") && icon2)
+		return icon2;
+	if (!strcmp(string, "Icon3") && icon3)
+		return icon3;
+	if (!strcmp(string, "Icon4") && icon4)
+		return icon4;
+	if (!strcmp(string, "IconBoom") && iconboom)
+		return iconboom;
 
 	/*
 	 * Here we start the game with property lists.

fookb/opts.h

@@ -8,17 +8,13 @@
 #ifndef PARAMS_H
 #define PARAMS_H
 
-#include <WINGs/WUtil.h>
 
 #ifdef WMAKER
 #define DEFAULTS_FILE "~/GNUstep/Defaults/FOOkb"
 #else
 #define DEFAULTS_FILE "~/.fookb"
 #endif				/* WMAKER */
 
-#include <X11/Xlib.h>		/* X Window standard header */
-#include <X11/Xresource.h>	/* X resource manager stuff */
-
 char *read_param(char *);
 
 #endif				/* PARAMS_H */