Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 1.409.0 #4530

Merged

Conversation

rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented Oct 15, 2024

🤖 I have created a release beep boop

1.409.0 (2024-10-16)

Features

  • frontend: unify all triggers UX and simplify flow settings (#4259) (91a3d06)
  • Scroll to element in virtual list when clicking on graph point (#4532) (7126ba1)
  • sso: adding the ability to define a custom display name for sso (#4529) (99c5b3e)

Bug Fixes

  • Add indexer backup lock to fit the deployment model (#4531) (411bce7)
  • app: accept connecting to non yet existing state output for convenience (9eb1ecc)
  • app: improve absolute url handling in download button and downloadFile (dcdbf1a)
  • app: make s3 uploads persistent across tabs change (c3b536b)
  • canceled jobs button reporting 0 jobs cancelled (#4534) (e736572)
  • python-client: improve get_job_status for running jobs (a8c4ea2)
  • ui: dark mode support for queue metrics based critical alert (#4535) (f38b3d1)

This PR was generated with Release Please. See documentation.


Important

Release 1.409.0 introduces frontend UX unification, SSO display name customization, and various bug fixes.

  • Features:
    • Unify all triggers UX and simplify flow settings in frontend.
    • Scroll to element in virtual list on graph point click.
    • Add custom display name for SSO.
  • Bug Fixes:
    • Add indexer backup lock for deployment model.
    • Improve app's absolute URL handling and S3 upload persistence.
    • Fix canceled jobs button reporting issue.
    • Enhance get_job_status in python-client for running jobs.
    • Support dark mode for queue metrics critical alert in UI.

This description was created by Ellipsis for 99193c6. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented Oct 15, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6525f9f
Status: ✅  Deploy successful!
Preview URL: https://fd3fbe50.windmill.pages.dev
Branch Preview URL: https://release-please--branches--ma.windmill.pages.dev

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3fae39a in 9 seconds

More details
  • Looked at 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version number has been correctly updated to 1.408.2, matching the release version in the PR description and changelog.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been correctly updated to 1.408.2, matching the release version in the PR description and changelog.

Workflow ID: wflow_zoQWzoFnhstqQcBt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 15c1efa to a664813 Compare October 15, 2024 07:48
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on a664813 in 10 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It currently matches the PR description, which is correct.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.408.2, matching the release version in the PR description.

Workflow ID: wflow_aj409ipXIfzfQ1v4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel changed the title chore(main): release 1.408.2 chore(main): release 1.409.0 Oct 15, 2024
@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 5a6eed2 to 21e8115 Compare October 15, 2024 15:34
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 21e8115 in 10 seconds

More details
  • Looked at 31 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be consistent with the release notes and changelog updates.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.409.0, which matches the release version in the PR description. This is a standard change for a release PR.

Workflow ID: wflow_NUnCAIdf8FMLMSIj


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 91cef14 to 3551ef9 Compare October 16, 2024 12:38
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3551ef9 in 9 seconds

More details
  • Looked at 33 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_40qWHE8BASA2zHOL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 3551ef9 to 49a73a2 Compare October 16, 2024 12:38
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 49a73a2 in 10 seconds

More details
  • Looked at 33 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt is correctly updated to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_o1aB40S1DC4N5Fcd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 8328c1e to 831f9d8 Compare October 16, 2024 14:16
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 831f9d8 in 10 seconds

More details
  • Looked at 34 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt is correctly updated to 1.409.0, matching the release version in the PR description. This is a standard change for a release PR.

Workflow ID: wflow_3Q0nRTKRC8uq8EOx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from e4e26dd to f152083 Compare October 16, 2024 14:28
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f152083 in 10 seconds

More details
  • Looked at 35 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number is correctly updated to match the new release version. This is important for consistency across the project.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The version number in version.txt should be updated to match the new release version. This is a common practice to ensure consistency across the project.

Workflow ID: wflow_9NffV2VaOpjfDJyc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 8a395a1 to 1b4e97b Compare October 16, 2024 15:48
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 1b4e97b in 9 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version number is correctly updated to 1.409.0, matching the release version in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt is correctly updated to 1.409.0, matching the release version in the PR description. No issues here.

Workflow ID: wflow_UcabRZORae5JLkz9


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 1b4e97b to 195f3ea Compare October 16, 2024 15:49
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 195f3ea in 9 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_QW2frc06Y757dxpL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on a874858 in 9 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure that the version number here matches the intended release version. It should be consistent with the changelog and PR description.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The version number in version.txt has been correctly updated to 1.409.0, matching the release version in the PR description. This is a standard change for a release PR.

Workflow ID: wflow_TtNJ2K1KKiSsjqap


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from f49aaa5 to 837c3ae Compare October 16, 2024 16:24
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 837c3ae in 10 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It currently matches the PR description, which is correct.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been correctly updated to 1.409.0, matching the release version in the PR description. This is a standard change for a release PR.

Workflow ID: wflow_r0SUhogblLyzE1na


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from ba0ef5a to d6c6b64 Compare October 16, 2024 17:21
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d6c6b64 in 9 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be consistent with the release notes and changelog.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The version number in version.txt has been correctly updated to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_q8hm0ZBNpilBujoz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from ce84cbf to 2268cc4 Compare October 16, 2024 17:24
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2268cc4 in 9 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_t5KbwUnDYj7Herbm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 68b2d53 to 16c1a38 Compare October 16, 2024 17:27
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 16c1a38 in 10 seconds

More details
  • Looked at 36 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been updated correctly to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_vKx7oSfkOAWQnGil


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 50746e7 to 7a353cb Compare October 16, 2024 17:45
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7a353cb in 17 seconds

More details
  • Looked at 37 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version.txt file should only contain the version number without any prefixes like 'L1:'.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment points out that the version number should not have a prefix like 'L1:'. The new content of the file includes 'L1:', which aligns with the comment's concern. This suggests that the comment is addressing a potential issue with the format of the version number.
    I might be missing context about whether the prefix 'L1:' is intentional or part of a new format. Without additional context, it's hard to be certain if this is an issue.
    The comment directly addresses the change made in the diff, and there is no indication that the prefix 'L1:' is intentional or correct. It's reasonable to assume the comment is valid based on the information given.
    The comment should be kept as it addresses a potential issue with the format of the version number in the version.txt file.

Workflow ID: wflow_vZxhjn66HATWzOpq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from 71795b4 to be2999c Compare October 16, 2024 17:52
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on be2999c in 14 seconds

More details
  • Looked at 37 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    The version.txt file should only contain the version number without any prefixes like 'L1:'.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_hNdjvRChu1Jc08Oq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel force-pushed the release-please--branches--main--components--windmill branch from a0a3416 to 99193c6 Compare October 16, 2024 18:10
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 99193c6 in 11 seconds

More details
  • Looked at 38 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. version.txt:1
  • Draft comment:
    Ensure the version number here matches the intended release version. It should be 1.409.0 as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version number in version.txt has been correctly updated to 1.409.0, matching the release version in the PR description.

Workflow ID: wflow_PKHS1aZrR748Ziv8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 8df2cec into main Oct 16, 2024
1 check passed
@rubenfiszel rubenfiszel deleted the release-please--branches--main--components--windmill branch October 16, 2024 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
@rubenfiszel
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant