Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Areas not selected by the brush are edited #7

Open
BCL123456-BAL opened this issue Nov 7, 2023 · 1 comment
Open

Areas not selected by the brush are edited #7

BCL123456-BAL opened this issue Nov 7, 2023 · 1 comment

Comments

@BCL123456-BAL
Copy link

BCL123456-BAL commented Nov 7, 2023

Brush editing commands 1:
lego_0_instruction

Edit results:
view 1
lego_0
view 2
lego_1
view 3
lego_15

Brush editing commands 2:
lego_instruction_new

Edit results:
view 1
lego_0_new
view 2
lego_1_new
view 3
lego_15_new

I'm wondering why the large area in the middle of the right wheel is also edited. Hope you can give some advice.

@windingwind
Copy link
Owner

  1. In the first example, I guess certain stroke pixels go beyond the boundary of the wheel (though not distinguishable by human) and are mapped to the surface of the yellow blocks, which leads to the color leakage to the background.

  2. In our implementation, all points in one brush stroke are recognized and unified to a cube with rotation and translation. A circle stroke should be decomposed into several smaller line strokes theoretically, but technically we didn't implement that for the GUI.

So that's why you see the red leaks to the horizontal bar of the right wheel in second example.

I am sorry but we didn't (and never tried to) make the GUI perfect or reach product-level. Note that the GUI is just to show the possibility and ability of our pipeline proposed in the paper. As long as there's nothing too wrong, I think it's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants