Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new HMDHFDplus version #5

Open
timriffe opened this issue Feb 1, 2023 · 2 comments
Open

new HMDHFDplus version #5

timriffe opened this issue Feb 1, 2023 · 2 comments

Comments

@timriffe
Copy link
Contributor

timriffe commented Feb 1, 2023

Hi Frans! HMDHFDplus will soon have a new version on CRAN, which

  1. fixes the UTF-8 tail problem you pointed out in the HFD data
  2. now refers to the new HMD website and requires new HMD credentials.

The new version number will be 2.0.0; your code shouldn't need to change, unless you had a manual fix for the UTF-8 thing. You'll only need to specify a new minimum HMDHFDplus version number in your DESCRIPTION file. I expect the new version to be on CRAN in 2-3 days. All the best,
Tim

@willekens
Copy link
Owner

willekens commented Feb 1, 2023 via email

@timriffe
Copy link
Contributor Author

timriffe commented Feb 2, 2023

Of course, I've now made a pull request that addresses this and other things. CRAN noticed that your package would break if HMDHFDplus were updated as requested, so I took care of that here and there, you will have received a notification. Note the min package dependency is 2.0.01, and so the remote checks using github actions (not sure if you are using these or not, but I have them on my fork) won't be able to install VirtualPop to test it until HMDHFDplus is finally on CRAN. Sorry if that's confusing, but it should be sorted out in a day or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants