Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some source files from the libk #235

Open
willdurand opened this issue Jan 3, 2021 · 1 comment
Open

Exclude some source files from the libk #235

willdurand opened this issue Jan 3, 2021 · 1 comment
Labels
code quality component: kernel priority: p4 Issues at this priority level are "nice to have".

Comments

@willdurand
Copy link
Owner

We use __is_libk to control what goes where (i.e. libc only, libk only or both) but now we have source files that contain code for libc only and gcc warns us:

warning: ISO C forbids an empty translation unit [-Wpedantic]

We should exclude source files (.c) we know shouldn't be in the libk given that libk should be a subset of libc.

@willdurand willdurand added code quality component: kernel priority: p4 Issues at this priority level are "nice to have". labels Jan 3, 2021
@willdurand
Copy link
Owner Author

I don't know if that is still the case but the new(-ish) build system should allow us to only select the source files we want for libc and libk in a distinct manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality component: kernel priority: p4 Issues at this priority level are "nice to have".
Projects
None yet
Development

No branches or pull requests

1 participant