diff --git a/broker/src/main/java/io/moquette/imhandler/HandleFriendRequestHandler.java b/broker/src/main/java/io/moquette/imhandler/HandleFriendRequestHandler.java index 220d61151..7673bf7e0 100644 --- a/broker/src/main/java/io/moquette/imhandler/HandleFriendRequestHandler.java +++ b/broker/src/main/java/io/moquette/imhandler/HandleFriendRequestHandler.java @@ -19,6 +19,7 @@ import win.liyufan.im.IMTopic; import win.liyufan.im.MessageShardingUtil; +import static cn.wildfirechat.common.ErrorCode.ERROR_CODE_ALREADY_FRIENDS; import static cn.wildfirechat.common.ErrorCode.ERROR_CODE_SUCCESS; @Handler(IMTopic.HandleFriendRequestTopic) @@ -86,6 +87,10 @@ public ErrorCode action(ByteBuf ackPayload, String clientID, String fromUser, bo publisher.publishNotification(IMTopic.NotifyFriendTopic, fromUser, heads[1]); } } + if(errorCode == ERROR_CODE_ALREADY_FRIENDS) { + errorCode = ERROR_CODE_SUCCESS; + } + return errorCode; } } diff --git a/broker/src/main/java/io/moquette/persistence/MemoryMessagesStore.java b/broker/src/main/java/io/moquette/persistence/MemoryMessagesStore.java index bf45269cb..f8f82ad61 100755 --- a/broker/src/main/java/io/moquette/persistence/MemoryMessagesStore.java +++ b/broker/src/main/java/io/moquette/persistence/MemoryMessagesStore.java @@ -2856,7 +2856,7 @@ public ErrorCode SyncFriendRequestUnread(String userId, long unreadDt, long[] he public ErrorCode handleFriendRequest(String userId, WFCMessage.HandleFriendRequest request, WFCMessage.Message.Builder msgBuilder, long[] heads, boolean isAdmin) { HazelcastInstance hzInstance = m_Server.getHazelcastInstance(); - + boolean alreadyFriend = false; if(!isAdmin && request.getStatus() == ProtoConstants.FriendRequestStatus.RequestStatus_Accepted) { MultiMap friendsMap = hzInstance.getMultiMap(USER_FRIENDS); @@ -2868,10 +2868,9 @@ public ErrorCode handleFriendRequest(String userId, WFCMessage.HandleFriendReque for (FriendData fd : friends) { if (fd.getFriendUid().equals(request.getTargetUid())) { if (fd.getState() == 0) { - return ErrorCode.ERROR_CODE_ALREADY_FRIENDS; - } else { - break; + alreadyFriend = true; } + break; } } } @@ -2950,7 +2949,7 @@ public ErrorCode handleFriendRequest(String userId, WFCMessage.HandleFriendReque } if (existRequest != null) { - if (mFriendRequestExpiration > 0 && System.currentTimeMillis() - existRequest.getUpdateDt() > mFriendRequestExpiration) { + if (!alreadyFriend && mFriendRequestExpiration > 0 && System.currentTimeMillis() - existRequest.getUpdateDt() > mFriendRequestExpiration) { return ErrorCode.ERROR_CODE_FRIEND_REQUEST_EXPIRED; } else { existRequest = existRequest.toBuilder().setStatus(request.getStatus()).setUpdateDt(System.currentTimeMillis()).build(); @@ -2976,7 +2975,7 @@ public ErrorCode handleFriendRequest(String userId, WFCMessage.HandleFriendReque } } - if(request.getStatus() == ProtoConstants.FriendRequestStatus.RequestStatus_Accepted){ + if(!alreadyFriend && request.getStatus() == ProtoConstants.FriendRequestStatus.RequestStatus_Accepted){ MultiMap friendsMap = hzInstance.getMultiMap(USER_FRIENDS); FriendData friendData1 = new FriendData(userId, request.getTargetUid(), "", request.getExtra(), 0, 0, System.currentTimeMillis()); databaseStore.persistOrUpdateFriendData(friendData1); @@ -2997,6 +2996,9 @@ public ErrorCode handleFriendRequest(String userId, WFCMessage.HandleFriendReque callbackRelationEvent(userId, request.getTargetUid(), 0, "1"); } + if(alreadyFriend) { + return ErrorCode.ERROR_CODE_ALREADY_FRIENDS; + } return ErrorCode.ERROR_CODE_SUCCESS; } } else {