Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prompt for instance shutdown when Tale delete=409 #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Dec 19, 2022

Problem

We now have the option to force deletion of Tale instances from the UI, but UI needs to handle the new force API parameter

Fixes #229

Approach

  • Ask user for confirmation - if yes, shutdown running Instance(s) and delete the Tale

NOTE: there are two paths for this - the "Running Tales" section has its own handling that is separate from the rest of the page

Screen Shot 2022-12-19 at 1 29 45 PM

How to Test

Prerequisites: at least one Tale running that you own

  1. Checkout this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the Tale Catalog and find a Tale that you own
  4. Start the Tale, if you haven't already
    • You should be navigated to the Run Tale page
  5. Go back to the Tale Dashboard and click the X on the Tale to delete it
    • You should see the Delete Tale modal appear
  6. Confirm this modal and you should see a ConfirmationModal appear
    • You should see this modal warns you about running instances and the consequences for deleting them
  7. After confirming, you should see the Tale and Instances are now deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt user to delete tale with running instances
1 participant