Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_container only works if base image hasn't changed #143

Open
Xarthisius opened this issue Apr 30, 2021 · 0 comments
Open

update_container only works if base image hasn't changed #143

Xarthisius opened this issue Apr 30, 2021 · 0 comments

Comments

@Xarthisius
Copy link
Contributor

If user changes base image (e.g. from JupyterLab to RStudio) and invokes update_container the task will fail, as it's not sufficient to simply update service with a new image. A rough list of things that should be done:

  • verify if license volume should be mounted (modify service mounts)
  • modify labels using new container_config
  • modify command using new rendered_command
  • modify env using new container_config
  • modify resources using new container_config

It might be more practical to refactor _launch_container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant