Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Full Screen' feature on cuts off on Firefox #498

Open
ThomasThelen opened this issue Jun 17, 2019 · 1 comment
Open

The 'Full Screen' feature on cuts off on Firefox #498

ThomasThelen opened this issue Jun 17, 2019 · 1 comment

Comments

@ThomasThelen
Copy link
Member

When using the full screen feature on the browse page, the bottom cuts off. Note that this works fine in Chrome, and is relevant only to Firefox.

Steps to Reproduce

  1. Launch Whole Tale in Firefox
  2. Navigate to the Browse page
  3. Full screen the page (see gif below)

demo

@bodom0015
Copy link
Member

I'm willing to bet that the black area at the bottom has dimensions that are precisely equal to the dimensions of the navbar + the footer. Firefox always has issues with using height: fill-available, so I wouldn't be surprised if that is manifesting here in the opposite way.

If you'll recall, Firefox typically has issues where divs are not properly stretched to match the height of the parent in some cases (usually with Semantic's class="ui grid"- see #202 #410 #468 #403 #402). I'm willing to bet that this is another one of those cases, where the height of the "full screen" app isn't being properly stretched to match the viewport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants