Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less Spammy Telegram #323

Open
rcarmo opened this issue Jun 13, 2021 · 7 comments
Open

Less Spammy Telegram #323

rcarmo opened this issue Jun 13, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@rcarmo
Copy link
Collaborator

rcarmo commented Jun 13, 2021

Is your feature request related to a problem? Please describe.
Please disable candlestick detection messages in Telegram, since they can be quite spammy.

Describe the solution you'd like
A flag to mute them, set to default

Describe alternatives you've considered
Hacking that out of the code

@emreeroglu
Copy link
Collaborator

This will be configurable when Telegram integrated with logger. So user will be able to pick which level of logs to get Telegram.
Telegram (in general Chat) logs may be have a separate log level than logger so chat configuration would have a little more detail.

@whittlem
Copy link
Owner

I agree with @rcarmo that candlestick detection messages are spammy as a default. As a default Telegram should only be receiving buy and sell events. @emreeroglu if the user wants to receive more verbose messaging then they could increase the logging level as you describe. Are you able to help me remove those spammy messages as a default?

@whittlem whittlem added the enhancement New feature or request label Jun 16, 2021
@emreeroglu
Copy link
Collaborator

I would like to help, have some design ideas but need to finalize those and discuss with you so we can be future proof about possible new chat clients.

@hebawom
Copy link
Collaborator

hebawom commented Jun 18, 2021

I was at a wedding the other day and my watch kept pinging me candlesticks!

@devinat1
Copy link

I am writing this comment in agreement that it would be nice to customize which types of messages to receive from telegram (via the JSON file for example).

@Nicolas469
Copy link
Contributor

Any progress here ? I think that we have two options: one flag to disable candlestick detection or add a notification level.

@loomsen
Copy link
Collaborator

loomsen commented Aug 12, 2021

I was thinking about implementing telegram (and possibly other messengers) as logging handlers in python. Did a quick proof of concept:

image

Leads to:
image

So we could just use log.debug, log.error, log.info etc and let the handlers handle it. Console Handler will log to stdout/stderr, filehandler will log to file, and $messengerHandler will send messages to $messenger (extendable, we could easily add more messengers).
Also each Handler could have its own level, so telegram could have a higher level than log file, and the ConsoleHandler could have the lowest level, as an example.
Didn't have the time to implement, but it's not exactly rocket science, so if someone wants to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants